publish-commit-bottles: specify branch and remote in git-try-push
#126125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlocab
added
the
CI-syntax-only
BrewTestBot
added
automerge-skip
carlocab
commented
Mar 20, 2023
Comment on lines
+114
to
+121
| branch="$(git branch --show-current)" | ||
| if [[ -n "$branch" ]] | ||
| then | ||
| echo "branch=$branch" >> "$GITHUB_OUTPUT" | ||
| else | ||
| echo "::error ::Not on a branch!" | ||
| exit 1 | ||
| fi |
There was a problem hiding this comment.
This has an unhandled edge-case.
If the PR branch is also called master (or otherwise conflicts with a branch name in the homebrew/core repo on the runner), then git branch --show-current will return $username/master, which will not work for the git-try-push action below.
chenrui333
approved these changes
Mar 20, 2023
|
Shell scripts run in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for #125556.
Closes Homebrew/actions#338.