-
-
Notifications
You must be signed in to change notification settings - Fork 12.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chruby-fish 0.8.0 #1266
chruby-fish 0.8.0 #1266
Conversation
Would be good to do this if you could!
We only use this as a judge for new formulae. |
I was already looking into this, taking some inspiration from existing tests. For any substantial test to work though, I have to work with the Any thoughts on how to tackle this? |
Feels like this should probably |
Thanks 👍 fixed. |
|
||
test do | ||
output = `fish -ic '. #{share}/chruby/chruby.fish; chruby --version'` | ||
assert output.include?("chruby-fish") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use assert_match
instead of assert ...include?
9eecd80
to
ca97baf
Compare
Thanks for your contribution to Homebrew! Without people like you submitting PRs we couldn't run this project. You rock! |
brew install <formula>
(where<formula>
is the name of the formula you're submitting)?brew audit --strict --online <formula>
(after doingbrew install <formula>
)?The last one is unchecked due to:
I guess there is a new policy about package popularity? Should the package be removed from Homebrew? (those numbers are currently at 14, 7, 45).