workflows: add actionlint workflow #128075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
automerge-skip
🤔 but the file is here in my PR? Hm. |
MikeMcQuaid
approved these changes
Apr 11, 2023
carlocab
force-pushed
the
actionlint
branch
17 times, most recently
from
08b38e1
to
d752426
Compare
|
Ok, getting annotations to show up properly requires a hack that we already use in our |
chenrui333
approved these changes
Apr 11, 2023
MikeMcQuaid
approved these changes
Apr 12, 2023
.github/workflows/actionlint.yml
Outdated
Comment on lines
7
to
13
| paths: | ||
| - '.github/workflows/*.yml' | ||
| - '.github/workflows/*.yaml' | ||
| pull_request: | ||
| paths: | ||
| - '.github/workflows/*.yml' | ||
| - '.github/workflows/*.yaml' |
There was a problem hiding this comment.
I think this might mean if you open a PR on a non-fork branch this will run twice? No big deal but perhaps worth a post-merge test.
carlocab
commented
Apr 12, 2023
.github/actionlint-matcher.json
Outdated
There was a problem hiding this comment.
I’d like to keep this JSON file only in one place. I think that should be doable once Homebrew/brew#15210 is merged.
7 tasks
carlocab
force-pushed
the
actionlint
branch
5 times, most recently
from
6773977
to
eca911d
Compare
This will help automate avoiding actionlint errors in our workflow files.
carlocab
commented
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will help automate avoiding actionlint errors in our workflow files.