Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

viewvc: set maximum macOS #128608

Merged
merged 1 commit into from
May 23, 2023
Merged

viewvc: set maximum macOS #128608

merged 1 commit into from
May 23, 2023

Conversation

iMichka
Copy link
Member

@iMichka iMichka commented Apr 17, 2023

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@iMichka iMichka added the CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. label Apr 17, 2023
@github-actions github-actions bot added formula deprecated Formula deprecated macos-only Formula depends on macOS labels Apr 17, 2023
Formula/viewvc.rb Outdated Show resolved Hide resolved
Copy link
Member

@ZhongRuoyu ZhongRuoyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, upstream will provide support for Python 3 starting from their upcoming 1.3.x release series: https://github.com/viewvc/viewvc#requirements

So, maybe we can keep it as it is?

@iMichka iMichka requested a review from ZhongRuoyu April 17, 2023 20:17
@github-actions github-actions bot added formula disabled Formula disabled and removed formula deprecated Formula deprecated labels Apr 17, 2023
carlocab
carlocab previously approved these changes Apr 18, 2023
@carlocab carlocab dismissed their stale review April 18, 2023 00:55

Missed review comment

@SMillerDev
Copy link
Member

I'd rather reenable if they ever release that

@carlocab
Copy link
Member

We already have a workflow that disables deprecated formulae after a year, we can leave this till then I think. No real reason to rush this?

@SMillerDev
Copy link
Member

We already have a workflow that disables deprecated formulae after a year, we can leave this till then I think. No real reason to rush this?

I think that workflow is a neural net it's developers called @iMichka, but we could wait.

@iMichka
Copy link
Member Author

iMichka commented Apr 18, 2023

We already have a workflow that disables deprecated formulae after a year

We have a workflow that deletes disabled formulae after a year. Going from deprecation to disabled is a manual thing I do from time to time, based on a script written by @SMillerDev (I never had the courage to make it a proper brew command but maybe one day).

What is also happening is that I am working through the list of formulae that don't have a Ventura bottle: #123214. I had this deprecated formulae in the list, that's all.

Our rules say we can disable them after 3 months of deprecation, so I thought I would just do it. After being disabled there is still one full year before the final removal.

@github-actions

This comment was marked as outdated.

@github-actions github-actions bot added the stale No recent activity label May 10, 2023
@github-actions github-actions bot removed the stale No recent activity label May 10, 2023
Does not work on Ventura as Python 2 is gone on that OS
@github-actions github-actions bot added formula deprecated Formula deprecated and removed formula disabled Formula disabled labels May 16, 2023
@iMichka iMichka changed the title viewvc: disable viewvc: set maximum macOS May 16, 2023
@iMichka iMichka added the ready to merge PR can be merged once CI is green label May 22, 2023
@BrewTestBot BrewTestBot added this pull request to the merge queue May 23, 2023
Merged via the queue into Homebrew:master with commit 4f749b3 May 23, 2023
12 checks passed
@iMichka iMichka deleted the viewvc branch May 23, 2023 20:29
@github-actions github-actions bot added the outdated PR was locked due to age label Jun 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. formula deprecated Formula deprecated macos-only Formula depends on macOS outdated PR was locked due to age ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants