lazygit 0.38.1 #129939
Closed
lazygit 0.38.1 #129939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
go
jesseduffield
force-pushed
the
bump-lazygit-0.38.1
branch
from
db8ef27
to
75a15ec
Compare
|
The last PR had an issue with the test so I fixed that up |
SMillerDev
reviewed
May 2, 2023
Formula/lazygit.rb
Outdated
| assert_match "foo", (testpath/"git-rebase-todo").read | ||
| ENV["LAZYGIT_DAEMON_KIND"] = "1" # exit immediately | ||
| ENV["LAZYGIT_DAEMON_INSTRUCTION"] = "{}" | ||
| ok = system "#{bin}/lazygit" |
There was a problem hiding this comment.
Wouldn't this just print the help text?
Formula/lazygit.rb
Outdated
Comment on lines
31
to
32
| # assert that the command exits with exit code 0 | ||
| assert_equal true, ok |
There was a problem hiding this comment.
System already fails if it does
There was a problem hiding this comment.
I'm surprised if that's true because the test fails upon comparing true to nil. If system raised an exception upon failure, I wouldn't expect it to reach the next line.
EDIT: actually it's just occurred to me that this system method may be homebrew-specific, and that it returns nil upon success. That makes sense.
jesseduffield
force-pushed
the
bump-lazygit-0.38.1
branch
from
75a15ec
to
ed73776
Compare
jesseduffield
commented
May 3, 2023
| system "#{bin}/lazygit", "git-rebase-todo" | ||
| assert_match "foo", (testpath/"git-rebase-todo").read | ||
| assert_match "pick 401a0c3", (testpath/"git-rebase-todo").read |
There was a problem hiding this comment.
The original issue was that we changed the interface here so I'm now just updating to reflect that
|
I'm gonna close this and reopen a PR for v0.38.2 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
action-homebrew-bump-formulaCreated with
brew bump-formula-pr.