New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rio 0.0.7 (new formula) #134295
rio 0.0.7 (new formula) #134295
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request. |
@carlocab do you want me to squash the commits? |
e521cf7
to
b6403d9
Compare
@carlocab the x86_64 fail ("Request adapter") is due to the GPU access in the x86 runner machines (not sure how the setup is made) but Rio doesn't provide CPU rendering, which means that a runner without GPU will never pass in that test (e.g containers). The Arm runners though provide a valid GPU. Do you know if is possible to configure x86_64 with GPU config or maybe only run the second test in ARMs? Other question I have is regarding the Linux build that's being triggered, is that a default (even if decide to skip Linux distribution)? Thanks in advance 🙏 |
that is default, we have to mark the build as |
you can find the macos only formulae in this repo. |
gotcha thank you @chenrui333 , updated with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks; one suggestion and a question.
It would also be good if you could squash all your commits together, after making any further changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingbrew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?It follows same build strategy as NixOS (NixOS/nixpkgs#237664) and Arch (https://aur.archlinux.org/packages/rio)