Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rio 0.0.7 (new formula) #134295

Merged
merged 2 commits into from Jun 28, 2023
Merged

rio 0.0.7 (new formula) #134295

merged 2 commits into from Jun 28, 2023

Conversation

raphamorim
Copy link
Contributor

@raphamorim raphamorim commented Jun 20, 2023

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

It follows same build strategy as NixOS (NixOS/nixpkgs#237664) and Arch (https://aur.archlinux.org/packages/rio)

@github-actions github-actions bot added autosquash Automatically squash pull request commits according to Homebrew style. new formula PR adds a new formula to Homebrew/homebrew-core rust Rust use is a significant feature of the PR or issue labels Jun 20, 2023
Copy link
Contributor

@avelino avelino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Formula/rio.rb Outdated Show resolved Hide resolved
Formula/rio.rb Outdated Show resolved Hide resolved
Formula/rio.rb Outdated Show resolved Hide resolved
Formula/rio.rb Outdated Show resolved Hide resolved
Formula/rio.rb Show resolved Hide resolved
@carlocab carlocab changed the title add Rio terminal formula rio 0.0.7 (new formula) Jun 20, 2023
@github-actions
Copy link
Contributor

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

Formula/rio.rb Outdated Show resolved Hide resolved
@raphamorim
Copy link
Contributor Author

@carlocab do you want me to squash the commits?

@raphamorim raphamorim force-pushed the master branch 4 times, most recently from e521cf7 to b6403d9 Compare June 20, 2023 21:29
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Jun 20, 2023
@raphamorim
Copy link
Contributor Author

raphamorim commented Jun 20, 2023

@carlocab the x86_64 fail ("Request adapter") is due to the GPU access in the x86 runner machines (not sure how the setup is made) but Rio doesn't provide CPU rendering, which means that a runner without GPU will never pass in that test (e.g containers). The Arm runners though provide a valid GPU. Do you know if is possible to configure x86_64 with GPU config or maybe only run the second test in ARMs?

Other question I have is regarding the Linux build that's being triggered, is that a default (even if decide to skip Linux distribution)?

Thanks in advance 🙏

@chenrui333 chenrui333 added the ready to merge PR can be merged once CI is green label Jun 20, 2023
@chenrui333
Copy link
Member

Other question I have is regarding the Linux build that's being triggered, is that a default (even if decide to skip Linux distribution)?

that is default, we have to mark the build as depends_on :macos to ignore it

@chenrui333
Copy link
Member

chenrui333 commented Jun 20, 2023

Other question I have is regarding the Linux build that's being triggered, is that a default (even if decide to skip Linux distribution)?

that is default, we have to mark the build as depends_on :macos to ignore it

you can find the macos only formulae in this repo.

@github-actions github-actions bot added autosquash Automatically squash pull request commits according to Homebrew style. macos-only Formula depends on macOS labels Jun 20, 2023
@raphamorim
Copy link
Contributor Author

gotcha thank you @chenrui333 , updated with depends_on :macos and added a livecheck

Formula/rio.rb Outdated Show resolved Hide resolved
@chenrui333 chenrui333 added CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. and removed ready to merge PR can be merged once CI is green labels Jun 20, 2023
Formula/rio.rb Outdated Show resolved Hide resolved
Formula/rio.rb Outdated Show resolved Hide resolved
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks; one suggestion and a question.

It would also be good if you could squash all your commits together, after making any further changes.

Formula/rio.rb Outdated Show resolved Hide resolved
Formula/rio.rb Show resolved Hide resolved
Formula/rio.rb Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Jun 27, 2023
@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Jun 27, 2023
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Jun 27, 2023
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@carlocab carlocab added the ready to merge PR can be merged once CI is green label Jun 27, 2023
Formula/rio.rb Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Jun 28, 2023
@BrewTestBot BrewTestBot added this pull request to the merge queue Jun 28, 2023
Merged via the queue into Homebrew:master with commit 2d8a2c0 Jun 28, 2023
12 checks passed
@github-actions github-actions bot added the outdated PR was locked due to age label Jul 29, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. macos-only Formula depends on macOS new formula PR adds a new formula to Homebrew/homebrew-core outdated PR was locked due to age ready to merge PR can be merged once CI is green rust Rust use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants