Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ettercap: switch to openssl@3 #134529

Merged
merged 2 commits into from Jun 26, 2023
Merged

ettercap: switch to openssl@3 #134529

merged 2 commits into from Jun 26, 2023

Conversation

chenrui333
Copy link
Member

See #134251.

@chenrui333 chenrui333 added openssl-3-migration Related to switching to an OpenSSL 3 dependency staging-branch-pr This pull request targets a *-staging branch. labels Jun 22, 2023
@chenrui333 chenrui333 mentioned this pull request Jun 22, 2023
Closed
@chenrui333
Copy link
Member Author 

  -- Could NOT find BISON (missing: BISON_EXECUTABLE)

@chenrui333
Copy link
Member Author 

  /tmp/ettercap-20230622-34350-1x2tgkh/ettercap-0.8.3.1/plug-ins/sslstrip/sslstrip.c:57:2: error: #error libcurl 7.26.0 or up is needed
     57 | #error libcurl 7.26.0 or up is needed
        |  ^~~~~

@chenrui333 chenrui333 added CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. build failure CI fails while building the software linux Linux is specifically affected labels Jun 22, 2023
@carlocab carlocab force-pushed the ettercap-openssl3 branch 2 times, most recently from cfda4c6 to c61a763 Compare June 23, 2023 16:57
@cho-m
Copy link
Member

cho-m commented Jun 23, 2023

Ettercap/ettercap@4053466

@chenrui333 @carlocab
ettercap: switch to openssl@3
77d284a 
Signed-off-by: Rui Chen <rui@chenrui.dev>

ettercap: needs bison for build

Signed-off-by: Rui Chen <rui@chenrui.dev>
@carlocab carlocab added ready to merge PR can be merged once CI is green and removed build failure CI fails while building the software linux Linux is specifically affected labels Jun 26, 2023
carlocab
carlocab approved these changes Jun 26, 2023
View reviewed changes
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linkage ✅

@carlocab carlocab requested a review from p-linnane June 26, 2023 15:34
@github-actions
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Jun 26, 2023
@BrewTestBot BrewTestBot merged commit 3bd92bd into openssl-migration-staging Jun 26, 2023
12 checks passed
@BrewTestBot BrewTestBot deleted the ettercap-openssl3 branch June 26, 2023 16:02
@github-actions github-actions bot added the outdated PR was locked due to age label Jul 27, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@carlocab carlocab carlocab approved these changes

@github-actions github-actions[bot] github-actions approved these changes

@p-linnane p-linnane p-linnane approved these changes

Assignees
No one assigned
Labels
CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. openssl-3-migration Related to switching to an OpenSSL 3 dependency outdated PR was locked due to age ready to merge PR can be merged once CI is green staging-branch-pr This pull request targets a *-staging branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@chenrui333 @cho-m @carlocab @p-linnane @BrewTestBot