openssh: inreplace to apply workaround to Apple clang 14.0.3

[cho-m]

• Have you followed the guidelines for contributing?
• Have you ensured that your commits follow the commit style guide?
• Have you checked that there aren't other open pull requests for the same formula update/change?
• Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
• Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

---

[cho-m]

Corresponding configure.ac:

	# clang 15 seems to have a bug in -fzero-call-used-regs=all.  See
	# https://bugzilla.mindrot.org/show_bug.cgi?id=3475 and
	# https://github.com/llvm/llvm-project/issues/59242
	case "$CLANG_VER" in
	15.*) OSSH_CHECK_CFLAG_COMPILE([-fzero-call-used-regs=used]) ;;
	*)    OSSH_CHECK_CFLAG_COMPILE([-fzero-call-used-regs=all]) ;;
	esac

Apple clang 14.0.3 is based on LLVM 15. Upstream fix would require changing configure.ac logic to detect this particular version. Just using simple inreplace for now and maybe we can add details to existing upstream bug.

Haven't checked if root cause of every reported OpenSSH issue, but worked for me locally to fix segfault issue.

Corresponding LLVM bug fix https://reviews.llvm.org/D139679 went in 15.0.7. Looks like it was zeroing out some registers which could lead to original ssh-keygen issue (i.e. argc/argv getting zeroed) and the segfault issue where some variables were NULL.

[mitchblank]

I know that right now this is just in testing, but please bump revision for this when it ships.

I've had a couple times recently where I've hit problems in homebrew only to find that the underlying bug has been fixed and re-bottled so I needed to manually brew reinstall to fix my machine. The current openssh package is pretty busted (at least on Intel) so I think it would definitely be wise to force an upgrade to the fixed bottles when they are available.

[Bo98]

Sounds like llvm/llvm-project#57692 so this is looking like the correct fix.

[github-actions]

🤖 An automated task has requested bottles to be published to this PR.

[github-actions]

⚠️ Bottle publish failed. CC @carlocab

[github-actions]

🤖 An automated task has requested bottles to be published to this PR.