genders 1.22 #1366
Closed
genders 1.22 #1366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compile with --with-java-extensions=no because the build is broken. note that current version 1.20 lead to segmentation fault when using psdh with genders
| @@ -16,6 +16,8 @@ class Genders < Formula | |||
| def install | |||
| args = ["--prefix=#{prefix}"] | |||
|
|
|||
| args << "--with-java-extensions=no" | |||
There was a problem hiding this comment.
Since this isn't a conditional configure argument (unlike the one just below), you can merge it with the initialization of the args array from above like this:
args = %W[
--prefix=#{prefix}
--with-java-extensions=no
]
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
compile with --with-java-extensions=no because the build is broken.
note that current version 1.20 lead to segmentation fault when
using psdh with genders