Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shard all of homebrew/core formulae into subdirectories #139592

Merged
merged 1 commit into from
Aug 15, 2023
Merged

Shard all of homebrew/core formulae into subdirectories #139592

merged 1 commit into from
Aug 15, 2023

Conversation

MikeMcQuaid
Copy link
Member

Now that all known sharding issues have been fixed: let's shard the remaining formulae in homebrew/core.

Note:

  • when merged this may require all existing PRs to be rebased
  • I'd like to merge this ASAP unless CI is failing or there's any known blockers as any PRs merged in homebrew/core will require this to be rebased

@MikeMcQuaid MikeMcQuaid added the CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. label Aug 15, 2023
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Aug 15, 2023
@fxcoudert
Copy link
Member

The aliases for formulas starting with a have been double-sharded :)

lrwxr-xr-x  1 fx  admin    24B Aug 15 14:56 arpack-ng -> ../Formula/a/a/arpack.rb
lrwxr-xr-x  1 fx  admin    23B Aug 15 14:56 atkmm@2.36 -> ../Formula/a/a/atkmm.rb
lrwxr-xr-x  1 fx  admin    26B Aug 15 14:56 autoconf@2.71 -> ../Formula/a/a/autoconf.rb

Taking care of that

@fxcoudert fxcoudert self-requested a review August 15, 2023 13:12
fxcoudert
fxcoudert requested changes Aug 15, 2023
View reviewed changes
Copy link
Member

@fxcoudert fxcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⛔️ All b* formulas are deleted by this PR

@MikeMcQuaid
Shard all of homebrew/core formulae into subdirectories
442f9cc 
Now that all known sharding issues have been fixed: let's shard the
remaining formulae in homebrew/core.
@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Aug 15, 2023
@Bo98 Bo98 removed this pull request from the merge queue due to a manual request Aug 15, 2023
@Bo98 Bo98 merged commit 6199ea4 into master Aug 15, 2023
13 of 14 checks passed
@Bo98 Bo98 deleted the shard_all branch August 15, 2023 13:47
@carlocab carlocab mentioned this pull request Aug 15, 2023
Merged
6 tasks
@pendo324 pendo324 mentioned this pull request Aug 15, 2023
Merged
@chenrui333 chenrui333 mentioned this pull request Aug 17, 2023
Closed
6 tasks
@raulcd raulcd mentioned this pull request Aug 23, 2023
Closed
@amacneil amacneil mentioned this pull request Aug 26, 2023
Closed
@jtbandes jtbandes mentioned this pull request Aug 28, 2023
Merged
jtbandes added a commit to foxglove/mcap that referenced this pull request Aug 28, 2023
@jtbandes
Update Homebrew formula path (#954)
c0a4720 
### Public-Facing Changes

None

### Description

Update Homebrew formula path which changed in
Homebrew/homebrew-core#139592.

Relates to FG-4760
@beeme1mr beeme1mr mentioned this pull request Aug 31, 2023
Closed
@williammartin williammartin mentioned this pull request Sep 1, 2023
Closed
paul-dingemans added a commit to pinterest/ktlint that referenced this pull request Sep 5, 2023
@paul-dingemans
Add brew formula path
5dd9bbd 
Brew formula has been relocated (Homebrew/homebrew-core#139592). The default formula path as resolved by GitHub action is no longer valid and needs to be overridden (mislav/bump-homebrew-formula-action#58).
@paul-dingemans paul-dingemans mentioned this pull request Sep 5, 2023
Merged
9 tasks
paul-dingemans added a commit to pinterest/ktlint that referenced this pull request Sep 5, 2023
@paul-dingemans
Add brew formula path (#2236)
a510eed 
Brew formula has been relocated (Homebrew/homebrew-core#139592). The default formula path as resolved by GitHub action is no longer valid and needs to be overridden (mislav/bump-homebrew-formula-action#58).
This was referenced Sep 8, 2023
Merged
Merged
@github-actions github-actions bot added the outdated PR was locked due to age label Sep 15, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fxcoudert fxcoudert fxcoudert approved these changes

Assignees
No one assigned
Labels
automerge-skip `brew pr-automerge` will skip this pull request CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MikeMcQuaid @fxcoudert @Bo98