nginx: use consistent service run. #139680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As-of Homebrew/brew#15875 being merged and tagged: this will no longer be needed.
carlocab
reviewed
Aug 16, 2023
| @@ -146,11 +146,7 @@ def caveats | |||
| end | |||
|
|
|||
| service do | |||
| if OS.linux? | |||
| run [opt_bin/"nginx", "-g", "'daemon off;'"] | |||
There was a problem hiding this comment.
I think this was needed for the generated service file too, which Homebrew/brew#15875 doesn't handle.
There was a problem hiding this comment.
Well spotted, have opened Homebrew/brew#15880 to handle.
p-linnane
approved these changes
Aug 23, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As-of Homebrew/brew#15875 and Homebrew/brew#15880 being merged and tagged: this will no longer be needed.