cloud-sql-proxy v2.6.1 (new formula) #140782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
go
chenrui333
reviewed
Aug 29, 2023
github-actions
bot
added
the
autosquash
SMillerDev
reviewed
Aug 30, 2023
Formula/c/cloud-sql-proxy.rb
Outdated
|
|
||
| test do | ||
| assert_match "cloud-sql-proxy version #{version}", shell_output("#{bin}/cloud-sql-proxy --version") | ||
| assert_match "could not find default credentials", shell_output("echo $(#{bin}/cloud-sql-proxy test 2>&1)") |
There was a problem hiding this comment.
Suggested change
| assert_match "could not find default credentials", shell_output("echo $(#{bin}/cloud-sql-proxy test 2>&1)") | |
| assert_match "could not find default credentials", shell_output("#{bin}/cloud-sql-proxy test 2>&1") |
There was a problem hiding this comment.
The echo here is used to suppress the exit 1 return status code (see other example in kamel.rb).
I found a better way to handle it using the second argument of shell_output though, thanks!
There was a problem hiding this comment.
Ah yeah, Kamel shouldn't do that either.
SMillerDev
approved these changes
Aug 30, 2023
cloud-sql-proxy v2.6.1 (add test case) cloud-sql-proxy v2.6.1 (fix test case) cloud-sql-proxy v2.6.1 (add livecheck) cloud-sql-proxy: use default livecheck Signed-off-by: Rui Chen <rui@chenrui.dev>
chenrui333
force-pushed
the
cloud-sql-proxy
branch
from
d5069af
to
ba546f9
Compare
chenrui333
approved these changes
Aug 30, 2023
github-actions
bot
removed
the
autosquash
|
@jhandguy thanks for your first PR to homebrew-core! 🎉 |
github-actions
bot
added
the
CI-published-bottle-commits
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?