openfortivpn 1.4.0 (new formula)

[mnencia]

openfortivpn is a client for PPP+SSL VPN tunnel services. It spawns a pppd
process and operates the communication between the gateway and this process.

It is compatible with Fortinet VPNs.

• Have you followed the guidelines for contributing?
• Have you checked that there aren't other open pull requests for the same formula update/change?
• Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

---

[ilovezfs]

@BrewTestBot test this please

[dunn]

These paths can't be specified as arguments to configure?

[mnencia]

I've checked, and unfortunately this is the only way with the current source.

This is basically a transcription of the macOS installing instructions provided by the software author in https://github.com/adrienverge/openfortivpn/blob/master/README.md

[dunn]

Is there no autogen.sh script?

[mnencia]

No, there isn't

[dunn]

A test that checks more functionality would be great!

[mnencia]

This is a VPN software, I've no idea on how to check its functionality without connecting to a server. --help and --version are the only informative functions provided by openfortivpn

The only tests included in the source are about code formatting, so nothing useful to check if the software works.

[dunn]

Gotcha, thanks.

[dunn]

Would you mind asking the developers if they'd consider adding a autogen.sh-style script, and patching configure to allow specifying the OpenSSL path?

[mnencia]

I've made a pull request to openfortivpn to fix these issues. adrienverge/openfortivpn#144

[JCount]

@mnencia If you would like, it may make the most sense to close this PR and open a new one for the new 1.4.0 release, but if you want to simply update this in place that is fine as well. Good work with the openfortivpn PR. 😄

[mnencia]

I've updated this pull request to 1.4.0 version

[dunn]

Thanks for contributing to Homebrew! Merged as 22d6d1d.

[DimitriPapadopoulos]

@mnencia @dunn FYI the autotools files in openfortivpn have been changed again. They now make use of pkg-config which seems like the right thing to do on Linux and BSD systems. To pick an alternate OpenSSL library, you may have to define PKG_CONFIG_PATH. Does this work with Homebrew or do you need option --with-openssl back?

See adrienverge/openfortivpn@70c5ed1.

[mnencia]

It should work.
There are two other formula that are using that approach: curl.rb and xmount.rb
However I'd like to know what @dunn thinks from the style point of view.

[mrbaseman]

My colleague has reported that the new formula works like charm 👍
To my understanding it uses the 1.4.0 release whereas the master branch has switched to pkg-config. On the other hand I did not see the formula itself making use of either of these options. But probably the core brings in support for such configure options (maybe both variants?).

[mnencia]

@mrbaseman the change has not yet been released. What @DimitriPapadopoulos was asking is if this change is compatible with Homebrew or they need to modify it before the next release.

My answer is: The formula has to be updated, but the change is fine.

I don't know if @dunn wants to add anything.

[DimitriPapadopoulos]

@mnencia Have you had the chance to test openfortivpn 1.5.0 yet?

Please note that Autotools support for OpenSSL has been rewritten in openfortivpn and hopefully standardized. The --with-openssl option is gone, you may use PKG_CONFIG_PATH instead.

[mnencia]

I've tested it briefly and everything looks ok.

[DimitriPapadopoulos]

Ooops... I just noticed recent commit bf53714 by ilovezfs.
Thank you for the feedback!