libvpx: modify options to fix build #143547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The build for `libvpx` is failing on Sonoma with an `ld: unknown options: --no-undefined -soname --version-script` error. These options don't exist on macOS but there are corresponding ones that can be substituted in some cases.
samford
added
CI-skip-recursive-dependents
p-linnane
approved these changes
Sep 18, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?The build for
libvpxis failing on Sonoma with anld: unknown options: --no-undefined -soname --version-scripterror (see #142161 (comment)). These options don't exist on macOS but there are corresponding ones that can be substituted in some cases.These issues should be reported (and addressed) upstream but this PR will fix the build in the interim time. I'm knocking off for the night but if anyone wants to report these issues before I get a chance (here, I think: https://www.webmproject.org/code/bug-reporting/), feel free.
Edit: Superseded by #143754.