Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpm 4.19.0 #144033

Merged
merged 6 commits into from
Sep 25, 2023
Merged

rpm 4.19.0 #144033

merged 6 commits into from
Sep 25, 2023

Conversation

chenrui333
Copy link
Member

Created with brew bump-formula-pr.

@github-actions github-actions bot added lua Lua use is a significant feature of the PR or issue bump-formula-pr PR was created using `brew bump-formula-pr` labels Sep 19, 2023
@chenrui333 chenrui333 added help wanted Task(s) needing PRs from the community or maintainers in progress Stale bot should stay away labels Sep 19, 2023
@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Sep 19, 2023
@chenrui333 chenrui333 added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Sep 19, 2023
SMillerDev
SMillerDev reviewed Sep 20, 2023
View reviewed changes
Formula/r/rpm.rb Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Sep 20, 2023
@ZhongRuoyu ZhongRuoyu force-pushed the bump-rpm-4.19.0 branch 2 times, most recently from 314ed24 to bcb9ea7 Compare September 23, 2023 06:58
@ZhongRuoyu ZhongRuoyu added help wanted Task(s) needing PRs from the community or maintainers and removed help wanted Task(s) needing PRs from the community or maintainers CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Sep 23, 2023
@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Sep 23, 2023
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Sep 23, 2023
@ZhongRuoyu ZhongRuoyu force-pushed the bump-rpm-4.19.0 branch 2 times, most recently from d1462fa to 8b389f2 Compare September 23, 2023 17:54
@ZhongRuoyu ZhongRuoyu added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Sep 23, 2023
@ZhongRuoyu
Copy link
Member

ZhongRuoyu commented Sep 23, 2023 •
edited

I think we should consider making this Linux-only. It requires Linux-only elfutils, relies heavily on GNU extensions like strchrnul from strings.h and GLOB_ONLYDIR from glob.h, and has less (if any) practical usage outside of Linux.

Many of the above requirements used to be conditional when Autotools was used. But now with CMake this is just not possible to build without extensive patching.

CC @Homebrew/core for thoughts.

@github-actions github-actions bot added the linux-only Formula depends on Linux label Sep 23, 2023
@p-linnane
Copy link
Member

p-linnane commented Sep 23, 2023 •
edited

This should definitely be Linux only. We will need to adjust and remove the on_linux block, etc.

@ZhongRuoyu ZhongRuoyu force-pushed the bump-rpm-4.19.0 branch 3 times, most recently from bbb4cc1 to 8ba103b Compare September 24, 2023 01:46
@ZhongRuoyu ZhongRuoyu added workflows PR modifies GitHub Actions workflow files and removed workflows PR modifies GitHub Actions workflow files labels Sep 24, 2023
@chenrui333 chenrui333 added ready to merge PR can be merged once CI is green and removed help wanted Task(s) needing PRs from the community or maintainers in progress Stale bot should stay away labels Sep 25, 2023
chenrui333
chenrui333 commented Sep 25, 2023
View reviewed changes
Formula/r/rpm.rb
depends_on "libmagic"
depends_on :linux
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should probably log an upstream ticket about this

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were you able to log that ticket @chenrui333 ?

chenrui333
chenrui333 commented Sep 25, 2023
View reviewed changes
Formula/r/rpmspectool.rb
@@ -14,6 +14,7 @@ class Rpmspectool < Formula
sha256 cellar: :any_skip_relocation, x86_64_linux: "3b27e1de9b1da031214a7cfd84e39491faca0f84fa616f1f358b8602c7961bca"
end

depends_on :linux
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:sad:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah. I used rpm to query packages information rpm -qpil foo.rpm

@github-actions
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Sep 25, 2023
@BrewTestBot BrewTestBot added this pull request to the merge queue Sep 25, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 25, 2023
ZhongRuoyu
ZhongRuoyu reviewed Sep 25, 2023
View reviewed changes
Formula/r/rpm.rb Outdated
on_macos do
depends_on "libomp"
end
depends_on "zlib"

conflicts_with "rpm2cpio", because: "both install `rpm2cpio` binaries"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that despite the depends_on :linux condition, the conflict still needs to be on_linux only. rpm2cpio's conflicts_with is scoped.

  rpm
    * Formula rpm2cpio should also have a conflict declared with rpm

chenrui333 and others added 6 commits September 25, 2023 15:12
@chenrui333 @SMillerDev @ZhongRuoyu
rpm 4.19.0
3b38c7f 
Also, make this Linux-only. It requires Linux-only `elfutils`, relies
heavily on GNU extensions like `strchrnul` from `strings.h` and
`GLOB_ONLYDIR` from `glob.h`, and has less (if any) practical usage
outside of Linux. Many of the above requirements used to be conditional
when Autotools was used. But now with CMake this is just not possible to
build without extensive patching.

Co-authored-by: Sean Molenaar <SMillerDev@users.noreply.github.com>
Co-authored-by: Ruoyu Zhong <zhongruoyu@outlook.com>
@ZhongRuoyu
rpm2cpio: only conflict with rpm on Linux
841f829
@ZhongRuoyu
rpmspectool: make Linux-only
4e03d71 
Since `rpm` is now made Linux-only.
@BrewTestBot @ZhongRuoyu
rpm2cpio: update 1.4 bottle.
7bf7906
@BrewTestBot @ZhongRuoyu
rpm: update 4.19.0 bottle.
1a7d172
@BrewTestBot @ZhongRuoyu
rpmspectool: update 1.99.7 bottle.
1aa43d0
@ZhongRuoyu ZhongRuoyu added this pull request to the merge queue Sep 25, 2023
Merged via the queue into Homebrew:master with commit 43743c5 Sep 25, 2023
14 checks passed
@SMillerDev SMillerDev mentioned this pull request Oct 12, 2023
Closed
@jordansissel jordansissel mentioned this pull request Oct 15, 2023
Open
@github-actions github-actions bot added the outdated PR was locked due to age label Dec 1, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 1, 2023
@chenrui333 chenrui333 deleted the bump-rpm-4.19.0 branch January 22, 2024 17:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@glensc glensc glensc left review comments

@kishaningithub kishaningithub kishaningithub left review comments

@SMillerDev SMillerDev SMillerDev left review comments

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@fxcoudert fxcoudert fxcoudert approved these changes

@ZhongRuoyu ZhongRuoyu ZhongRuoyu approved these changes

@github-actions github-actions[bot] github-actions approved these changes

Assignees
No one assigned
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. linux-only Formula depends on Linux lua Lua use is a significant feature of the PR or issue outdated PR was locked due to age ready to merge PR can be merged once CI is green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@chenrui333 @ZhongRuoyu @p-linnane @MikeMcQuaid @glensc @kishaningithub @SMillerDev @fxcoudert @BrewTestBot