Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rust 1.72.1 #144059

Merged
merged 2 commits into from
Sep 23, 2023
Merged

rust 1.72.1 #144059

merged 2 commits into from
Sep 23, 2023

Conversation

chenrui333
Copy link
Member

@chenrui333 chenrui333 commented Sep 19, 2023 •
edited by ZhongRuoyu

Created by brew bump

Created with brew bump-formula-pr.

  • resource blocks have been checked for updates.

@github-actions github-actions bot added bump-formula-pr PR was created using `brew bump-formula-pr` CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. long build Needs CI-long-timeout labels Sep 19, 2023
@chenrui333
Copy link
Member Author

cargo tags did not get marked yet, https://github.com/rust-lang/cargo/tags

@ZhongRuoyu

This comment was marked as resolved.

Sign in to view
@chenrui333 chenrui333 mentioned this pull request Sep 20, 2023
Merged
@chenrui333 chenrui333 removed the CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. label Sep 21, 2023
@chenrui333
Copy link
Member Author

also removing build from source label as this is more of a patch version bump (to save some CI bandwidth)

@ZhongRuoyu
Copy link
Member

cargo tags did not get marked yet, https://github.com/rust-lang/cargo/tags

It's the same as 1.72.0, so we don't need to update the cargo resource here.

@github-actions github-actions bot added the CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. label Sep 21, 2023
@ZhongRuoyu ZhongRuoyu removed the CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. label Sep 21, 2023
@ZhongRuoyu

This comment was marked as resolved.

Sign in to view
ZhongRuoyu
ZhongRuoyu reviewed Sep 21, 2023
View reviewed changes
Formula/r/rust.rb Outdated Show resolved Hide resolved
@github-actions github-actions bot added the CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. label Sep 22, 2023
@chenrui333 chenrui333 added CI-long-timeout Use longer GitHub Actions CI timeout. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. and removed CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. labels Sep 22, 2023
@github-actions github-actions bot added the CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. label Sep 22, 2023
@chenrui333 chenrui333 removed the CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. label Sep 22, 2023
@github-actions github-actions bot added the CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. label Sep 22, 2023
@chenrui333 chenrui333 removed the CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. label Sep 22, 2023
@chenrui333
Copy link
Member Author

should be good now.

@chenrui333
Copy link
Member Author

cancelling the build, will do after llvm 17 bottle

@github-actions github-actions bot removed the CI-long-timeout Use longer GitHub Actions CI timeout. label Sep 22, 2023
@ZhongRuoyu
Copy link
Member

Pushed an update to migrate to llvm 17, while we wait.

@ZhongRuoyu
Copy link
Member

Pushed an update to migrate to llvm 17, while we wait.

Tried that locally and bumped into rust-lang/rust#116020. We'll do that in 1.73.0 (the next minor version bump) instead.

@ZhongRuoyu ZhongRuoyu added the CI-long-timeout Use longer GitHub Actions CI timeout. label Sep 23, 2023
@github-actions github-actions bot added the CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. label Sep 23, 2023
@ZhongRuoyu ZhongRuoyu removed the CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. label Sep 23, 2023
@github-actions github-actions bot added the CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. label Sep 23, 2023
@ZhongRuoyu ZhongRuoyu removed the CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. label Sep 23, 2023
@github-actions github-actions bot added the CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. label Sep 23, 2023
@ZhongRuoyu ZhongRuoyu removed the CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. label Sep 23, 2023
@chenrui333 @ZhongRuoyu
rust 1.72.1
ea7472c 
- Build with the Python from macOS.
- Instead of doing a full `git clone`, build Cargo from a source
  tarball.

Co-authored-by: Ruoyu Zhong <zhongruoyu@outlook.com>
@github-actions github-actions bot added the CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. label Sep 23, 2023
@ZhongRuoyu ZhongRuoyu removed the CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. label Sep 23, 2023
@github-actions github-actions bot removed the CI-long-timeout Use longer GitHub Actions CI timeout. label Sep 23, 2023
@ZhongRuoyu ZhongRuoyu added long build Needs CI-long-timeout ready to merge PR can be merged once CI is green and removed long build Needs CI-long-timeout labels Sep 23, 2023
@github-actions
Copy link
Contributor

:shipit: @fxcoudert has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Sep 23, 2023
@github-actions github-actions bot added the CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. label Sep 23, 2023
@BrewTestBot BrewTestBot added this pull request to the merge queue Sep 23, 2023
Merged via the queue into Homebrew:master with commit 0f6f1ef Sep 23, 2023
12 checks passed
@chenrui333 chenrui333 deleted the bump-rust-1.72.1 branch January 22, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZhongRuoyu ZhongRuoyu ZhongRuoyu approved these changes

@github-actions github-actions[bot] github-actions approved these changes

Assignees
No one assigned
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. long build Needs CI-long-timeout ready to merge PR can be merged once CI is green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@chenrui333 @ZhongRuoyu @BrewTestBot @fxcoudert