Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

open-mpi: fix issue with Xcode 15 #144554

Merged
merged 1 commit into from
Sep 21, 2023
Merged

open-mpi: fix issue with Xcode 15 #144554

merged 1 commit into from
Sep 21, 2023

Conversation

fxcoudert
Copy link
Member

Again, a “new linker” bug. See details in open-mpi/ompi#11935

@fxcoudert fxcoudert added sonoma-bottling CI-skip-recursive-dependents Pass --skip-recursive-dependents to brew test-bot. 14 Sonoma is specifically affected CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. and removed CI-skip-recursive-dependents Pass --skip-recursive-dependents to brew test-bot. labels Sep 21, 2023
@fxcoudert fxcoudert added this pull request to the merge queue Sep 21, 2023
Merged via the queue into Homebrew:master with commit eb7b75c Sep 21, 2023
22 of 23 checks passed
@fxcoudert fxcoudert deleted the openmpi branch September 21, 2023 13:47
lukeshingles added a commit to lukeshingles/homebrew-core that referenced this pull request May 11, 2024
@lukeshingles
Use new Apple linker only for C/C++
09ee1dd 
Flags to force the ld_classic linker were added in Homebrew#144554 to avoid issues with Xcode 15. However, some time between then and now (Xcode 15.3 and macOS Sonoma 14.4.1) the new linker seems to work for C/C++, although the Fortran test still fails when ld_new is used. In this PR, I have limited the ld_classic flag to only apply to mpifort wrapper compiler. My motivation for switching to the new linker for C++ is that it solves linker failures when I try to compile my C++ project with mpicxx -flto=auto and g++-14 as the host compiler.
lukeshingles added a commit to lukeshingles/homebrew-core that referenced this pull request May 11, 2024
@lukeshingles
open-mpi: Use new Apple linker for mpicc/mpicxx
7882cd3 
A Flag to force the ld_classic linker was added in Homebrew#144554 to avoid issues with Xcode 15. However, some time between then and now (Xcode 15.3 and macOS Sonoma 14.4.1) the new linker seems to work for C/C++, although the Fortran test still fails when ld_new is used. In this PR, I have limited the ld_classic flag to only apply to mpifort wrapper compiler. My motivation for switching to the new linker for C++ is that it solves linker failures when I try to compile my C++ project with mpicxx -flto=auto and g++-14 as the host compiler.
lukeshingles added a commit to lukeshingles/homebrew-core that referenced this pull request May 11, 2024
@lukeshingles
open-mpi: Use new Apple linker for mpicc/mpicxx
503b2af 
A flag to force the ld_classic linker was added in Homebrew#144554 to avoid issues with Xcode 15. However, some time between then and now (Xcode 15.3 and macOS Sonoma 14.4.1) the new linker seems to work for C/C++, although the Fortran test still fails when ld_new is used. In this PR, I have limited the ld_classic flag to only apply to mpifort wrapper compiler. My motivation for switching to the new linker for C++ is that it solves linker failures when I try to compile my C++ project with mpicxx -flto=auto and g++-14 as the host compiler.
@lukeshingles lukeshingles mentioned this pull request May 11, 2024
Merged
6 tasks
lukeshingles added a commit to lukeshingles/homebrew-core that referenced this pull request May 12, 2024
@lukeshingles
open-mpi: Use new Apple linker for mpicc/mpicxx
43adb7c 
A flag to force the ld_classic linker was added in Homebrew#144554 to avoid issues with Xcode 15. However, some time between then and now (Xcode 15.3 and macOS Sonoma 14.4.1) the new linker seems to work for C/C++, although the Fortran test still fails when ld_new is used. In this PR, I have limited the ld_classic flag to only apply to mpifort wrapper compiler. My motivation for switching to the new linker for C++ is that it solves linker failures when I try to compile my C++ project with mpicxx -flto=auto and g++-14 as the host compiler.
lukeshingles added a commit to lukeshingles/homebrew-core that referenced this pull request May 13, 2024
@lukeshingles
open-mpi: Use new Apple linker for mpicc/mpicxx
eec121a 
A flag to force the ld_classic linker was added in Homebrew#144554 to avoid issues with Xcode 15. However, some time between then and now (Xcode 15.3 and macOS Sonoma 14.4.1) the new linker seems to work for C/C++, although the Fortran test still fails when ld_new is used. In this PR, I have limited the ld_classic flag to only apply to mpifort wrapper compiler. My motivation for switching to the new linker for C++ is that it solves linker failures when I try to compile my C++ project with mpicxx -flto=auto and g++-14 as the host compiler.
fxcoudert pushed a commit to lukeshingles/homebrew-core that referenced this pull request May 17, 2024
@lukeshingles @fxcoudert
open-mpi: Use new Apple linker for mpicc/mpicxx
bdfbf87 
A flag to force the ld_classic linker was added in Homebrew#144554 to avoid issues with Xcode 15. However, some time between then and now (Xcode 15.3 and macOS Sonoma 14.4.1) the new linker seems to work for C/C++, although the Fortran test still fails when ld_new is used. In this PR, I have limited the ld_classic flag to only apply to mpifort wrapper compiler. My motivation for switching to the new linker for C++ is that it solves linker failures when I try to compile my C++ project with mpicxx -flto=auto and g++-14 as the host compiler.
lukeshingles added a commit to lukeshingles/homebrew-core that referenced this pull request May 17, 2024
@lukeshingles
open-mpi: Use new Apple linker for mpicc/mpicxx
e195409 
A flag to force the ld_classic linker was added in Homebrew#144554 to avoid issues with Xcode 15. However, some time between then and now (Xcode 15.3 and macOS Sonoma 14.4.1) the new linker seems to work for C/C++, although the Fortran test still fails when ld_new is used. In this PR, I have limited the ld_classic flag to only apply to mpifort wrapper compiler. My motivation for switching to the new linker for C++ is that it solves linker failures when I try to compile my C++ project with mpicxx -flto=auto and g++-14 as the host compiler.
lukeshingles added a commit to lukeshingles/homebrew-core that referenced this pull request May 17, 2024
@lukeshingles
open-mpi: Use new Apple linker for mpicc/mpicxx
78dd874 
A flag to force the ld_classic linker was added in Homebrew#144554 to avoid issues with Xcode 15. However, some time between then and now (Xcode 15.3 and macOS Sonoma 14.4.1) the new linker seems to work for C/C++, although the Fortran test still fails when ld_new is used. In this PR, I have limited the ld_classic flag to only apply to mpifort wrapper compiler. My motivation for switching to the new linker for C++ is that it solves linker failures when I try to compile my C++ project with mpicxx -flto=auto and g++-14 as the host compiler.
lukeshingles added a commit to lukeshingles/homebrew-core that referenced this pull request May 17, 2024
@lukeshingles
open-mpi: Use new Apple linker for mpicc/mpicxx
be10159 
A flag to force the ld_classic linker was added in Homebrew#144554 to avoid issues with Xcode 15. However, some time between then and now (Xcode 15.3 and macOS Sonoma 14.4.1) the new linker seems to work for C/C++, although the Fortran test still fails when ld_new is used. In this PR, I have limited the ld_classic flag to only apply to mpifort wrapper compiler. My motivation for switching to the new linker for C++ is that it solves linker failures when I try to compile my C++ project with mpicxx -flto=auto and g++-14 as the host compiler.
lukeshingles added a commit to lukeshingles/homebrew-core that referenced this pull request May 17, 2024
@lukeshingles
open-mpi: Use new Apple linker for mpicc/mpicxx
c30f64d 
A flag to force the ld_classic linker was added in Homebrew#144554 to avoid issues with Xcode 15. However, some time between then and now (Xcode 15.3 and macOS Sonoma 14.4.1) the new linker seems to work for C/C++, although the Fortran test still fails when ld_new is used. In this PR, I have limited the ld_classic flag to only apply to mpifort wrapper compiler. My motivation for switching to the new linker for C++ is that it solves linker failures when I try to compile my C++ project with mpicxx -flto=auto and g++-14 as the host compiler.
p-linnane pushed a commit to lukeshingles/homebrew-core that referenced this pull request May 17, 2024
@lukeshingles @p-linnane
open-mpi: Use new Apple linker for mpicc/mpicxx
1d59f4f 
A flag to force the ld_classic linker was added in Homebrew#144554 to avoid issues with Xcode 15. However, some time between then and now (Xcode 15.3 and macOS Sonoma 14.4.1) the new linker seems to work for C/C++, although the Fortran test still fails when ld_new is used. In this PR, I have limited the ld_classic flag to only apply to mpifort wrapper compiler. My motivation for switching to the new linker for C++ is that it solves linker failures when I try to compile my C++ project with mpicxx -flto=auto and g++-14 as the host compiler.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZhongRuoyu ZhongRuoyu ZhongRuoyu approved these changes

Assignees
No one assigned
Labels
14 Sonoma is specifically affected CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. sonoma-bottling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fxcoudert @ZhongRuoyu