Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libbpg: deprecate #146035

Merged
merged 1 commit into from
Sep 26, 2023
Merged

libbpg: deprecate #146035

merged 1 commit into from
Sep 26, 2023

Conversation

iMichka
Copy link
Member

@iMichka iMichka commented Sep 26, 2023

The binaries that are built segfault on macOS Ventura. I sent an email to upstream on 06/08/2023 but got not response There as been no new release since some time

bpgenc is segfaulting. I ran it through lldb, here is the output:

➜  Formula git:(master) lldb bpgenc /usr/local/Homebrew/Library/Homebrew/test/support/fixtures/test.png (lldb) target create "bpgenc"
warning: (x86_64) /usr/local/bin/bpgenc empty dSYM file detected, dSYM was created with an executable with no debug info. Current executable set to 'bpgenc' (x86_64).
(lldb) settings set -- target.run-args  "/usr/local/Homebrew/Library/Homebrew/test/support/fixtures/test.png" (lldb) run
Process 55734 launched: '/usr/local/bin/bpgenc' (x86_64) Process 55734 stopped
* thread #1, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x200a3c040) frame #0: 0x0000000100074378 bpgenc`_mh_execute_header + 476024 bpgenc`:
->  0x100074378 <+476024>: vmovdqu (%rdi,%r9), %ymm6
    0x10007437e <+476030>: vpmaxub %ymm0, %ymm6, %ymm6
    0x100074382 <+476034>: vpminub %ymm1, %ymm6, %ymm6
    0x100074386 <+476038>: vmovdqu %ymm6, (%rdi,%r9)
Target 0: (bpgenc) stopped.
(lldb) bt
* thread #1, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x200a3c040)
  * frame #0: 0x0000000100074378 bpgenc`_mh_execute_header + 476024 frame #1: 0x00000001002a428e bpgenc`unsigned int copy_count<32>(short*, short const*, long) + 136815 frame #2: 0x0000000100042ec5 bpgenc`_mh_execute_header + 274117 frame #3: 0x0000000100046481 bpgenc`_mh_execute_header + 287873 frame #4: 0x000000010000a55f bpgenc`_mh_execute_header + 42335
  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

The binaries that are built segfault on macOS Ventura.
I sent an email to upstream on 06/08/2023 but got not response
There as been no new release since some time

bpgenc is segfaulting. I ran it through lldb, here is the output:

➜  Formula git:(master) lldb bpgenc /usr/local/Homebrew/Library/Homebrew/test/support/fixtures/test.png
(lldb) target create "bpgenc"
warning: (x86_64) /usr/local/bin/bpgenc empty dSYM file detected, dSYM was created with an executable with no debug info.
Current executable set to 'bpgenc' (x86_64).
(lldb) settings set -- target.run-args  "/usr/local/Homebrew/Library/Homebrew/test/support/fixtures/test.png"
(lldb) run
Process 55734 launched: '/usr/local/bin/bpgenc' (x86_64)
Process 55734 stopped
* thread #1, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x200a3c040)
    frame #0: 0x0000000100074378 bpgenc`_mh_execute_header + 476024
bpgenc`:
->  0x100074378 <+476024>: vmovdqu (%rdi,%r9), %ymm6
    0x10007437e <+476030>: vpmaxub %ymm0, %ymm6, %ymm6
    0x100074382 <+476034>: vpminub %ymm1, %ymm6, %ymm6
    0x100074386 <+476038>: vmovdqu %ymm6, (%rdi,%r9)
Target 0: (bpgenc) stopped.
(lldb) bt
* thread #1, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x200a3c040)
  * frame #0: 0x0000000100074378 bpgenc`_mh_execute_header + 476024
    frame #1: 0x00000001002a428e bpgenc`unsigned int copy_count<32>(short*, short const*, long) + 136815
    frame #2: 0x0000000100042ec5 bpgenc`_mh_execute_header + 274117
    frame Homebrew#3: 0x0000000100046481 bpgenc`_mh_execute_header + 287873
    frame Homebrew#4: 0x000000010000a55f bpgenc`_mh_execute_header + 42335
@iMichka iMichka added the CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. label Sep 26, 2023
@github-actions github-actions bot added formula deprecated Formula deprecated missing license Formula has a missing license which should be added no Linux bottle Formula has no Linux bottle labels Sep 26, 2023
@BrewTestBot BrewTestBot added this pull request to the merge queue Sep 26, 2023
Merged via the queue into Homebrew:master with commit a54cf07 Sep 26, 2023
14 checks passed
@iMichka iMichka deleted the libbpg branch September 26, 2023 17:37
@github-actions github-actions bot added the outdated PR was locked due to age label Oct 27, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. formula deprecated Formula deprecated missing license Formula has a missing license which should be added no Linux bottle Formula has no Linux bottle outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants