Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bash-snippets 1.1.1 (new formula) #15107

Closed
wants to merge 3 commits into from
Closed

bash-snippets 1.1.1 (new formula) #15107

wants to merge 3 commits into from

Conversation

omBratteng
Copy link

@omBratteng omBratteng commented Jun 29, 2017

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

A collection of small bash scripts for heavy terminal users with no dependencies

@ilovezfs ilovezfs added the new formula PR adds a new formula to Homebrew/homebrew-core label Jun 30, 2017
@ilovezfs
Copy link
Contributor

I'd like to see this use the upstream install script (looks like the script needs a non-interactive mode) and pass a --prefix= parameter, and the test in the test do block should exercise and verify the software's functionality.

The upstream repository is only 4 days old, so this doesn't pass our notability requirements, but would be happy to revisit it at a later date. In the meantime I'd suggest creating your own tap instead.

Thanks!

@ilovezfs ilovezfs closed this Jun 30, 2017
@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new formula PR adds a new formula to Homebrew/homebrew-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants