Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node 21.0.0 #151438

Merged
merged 2 commits into from
Oct 22, 2023
Merged

node 21.0.0 #151438

merged 2 commits into from
Oct 22, 2023

Conversation

ZhongRuoyu
Copy link
Member

@ZhongRuoyu ZhongRuoyu commented Oct 17, 2023 •
edited

Created with brew bump-formula-pr.

  • resource blocks have been checked for updates.

@github-actions github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request bump-formula-pr PR was created using `brew bump-formula-pr` labels Oct 17, 2023
@chenrui333 chenrui333 added the long build Needs CI-long-timeout label Oct 17, 2023
@ZhongRuoyu ZhongRuoyu added CI-long-timeout Use longer GitHub Actions CI timeout. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Oct 18, 2023
@github-actions github-actions bot removed the CI-long-timeout Use longer GitHub Actions CI timeout. label Oct 18, 2023
@derrabus
Copy link
Contributor

I think it would make sense to add a node@20 formula at the same time because Node 20.x is going to be the next LTS release.

@github-actions

This comment was marked as resolved.

Sign in to view
@github-actions github-actions bot added the stale No recent activity label Oct 21, 2023
@github-actions github-actions bot closed this Oct 22, 2023
@ZhongRuoyu ZhongRuoyu reopened this Oct 22, 2023
@ZhongRuoyu ZhongRuoyu added CI-long-timeout Use longer GitHub Actions CI timeout. in progress Stale bot should stay away and removed stale No recent activity labels Oct 22, 2023
@ZhongRuoyu
Copy link
Member Author

I think it would make sense to add a node@20 formula at the same time because Node 20.x is going to be the next LTS release.

Yes. It takes a long time to build node, so instead of doing it here we can follow up with another PR.

@chenrui333 chenrui333 removed the automerge-skip `brew pr-automerge` will skip this pull request label Oct 22, 2023
@chenrui333 chenrui333 mentioned this pull request Oct 22, 2023
Merged
@github-actions github-actions bot removed the CI-long-timeout Use longer GitHub Actions CI timeout. label Oct 22, 2023
@chenrui333
Copy link
Member

chenrui333 commented Oct 22, 2023 •
edited

looks like these four formulae do not work with node21, checking in my local

brew test --retry --verbose cdktf
brew test --retry --verbose localtunnel
brew test --retry --verbose node-sass
brew test --retry --verbose quicktype

This was referenced Oct 22, 2023
Closed
Closed
@chenrui333
Copy link
Member

We can merge it now and quickly followup on the node@20 formula as well as patches for the four formula.

@github-actions
Copy link
Contributor

:shipit: @chenrui333 has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Oct 22, 2023
@BrewTestBot BrewTestBot added this pull request to the merge queue Oct 22, 2023
Merged via the queue into Homebrew:master with commit 1f1cc5d Oct 22, 2023
12 checks passed
@ZhongRuoyu ZhongRuoyu mentioned this pull request Oct 22, 2023
Merged
6 tasks
@ZhongRuoyu ZhongRuoyu deleted the bump-node-21.0.0 branch October 22, 2023 17:58
@ZhongRuoyu ZhongRuoyu mentioned this pull request Oct 22, 2023
Merged
6 tasks
@chenrui333 chenrui333 mentioned this pull request Oct 22, 2023
Merged
@github-actions github-actions bot added the outdated PR was locked due to age label Nov 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chenrui333 chenrui333 chenrui333 approved these changes

@github-actions github-actions[bot] github-actions approved these changes

Assignees
No one assigned
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. in progress Stale bot should stay away long build Needs CI-long-timeout outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ZhongRuoyu @derrabus @chenrui333 @BrewTestBot