Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llm: migrate to python@3.12 #151467

Merged
merged 2 commits into from Oct 17, 2023
Merged

llm: migrate to python@3.12 #151467

merged 2 commits into from Oct 17, 2023

Conversation

chenrui333
Copy link
Member

llm: migrate to python@3.12

@github-actions github-actions bot added python Python use is a significant feature of the PR or issue rust Rust use is a significant feature of the PR or issue labels Oct 17, 2023
@chenrui333
Copy link
Member Author

ModuleNotFoundError: No module named 'pkg_resources'

Signed-off-by: Rui Chen <rui@chenrui.dev>

llm: need `python-setuptools`

Signed-off-by: Rui Chen <rui@chenrui.dev>
@github-actions
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Oct 17, 2023
@BrewTestBot BrewTestBot added this pull request to the merge queue Oct 17, 2023
Merged via the queue into Homebrew:master with commit bb35cb1 Oct 17, 2023
12 checks passed
@simonw
Copy link
Contributor

simonw commented Oct 28, 2023

Unfortunately, upgrading to Python 3.12 means that LLM plugins that depend on PyTorch no longer work:

@simonw
Copy link
Contributor

simonw commented Oct 28, 2023

Would it make sense to downgrade to Python 3.11 again until PyTorch release their 3.12 update?

Plugins are an important piece of LLM. The most recent plugin adds support for the new Jina AI embedding models, but no longer works because it depends on PyTorch: https://simonwillison.net/2023/Oct/26/llm-embed-jina/

@github-actions github-actions bot added the outdated PR was locked due to age label Nov 28, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 28, 2023
@chenrui333 chenrui333 deleted the llm-py3.12 branch January 22, 2024 19:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. outdated PR was locked due to age python Python use is a significant feature of the PR or issue python-3.12-migration rust Rust use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants