Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests on 10.13 due to /usr/local/lib being MIA #15289

Merged
merged 23 commits into from Jul 5, 2017

Conversation

ilovezfs
Copy link
Contributor

@ilovezfs ilovezfs commented Jul 4, 2017

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

no /usr/local/lib for you
no /usr/local/lib for you
no /usr/local/lib for you
no /usr/local/lib for you
no /usr/local/lib for you
no /usr/local/lib for you
no /usr/local/lib for you
no /usr/local/lib for you
no /usr/local/lib for you
no /usr/local/lib for you
no /usr/local/lib for you
no /usr/local/lib for you
no /usr/local/lib for you
no /usr/local/lib for you
no /usr/local/lib for you
no /usr/local/lib for you
@ilovezfs
Copy link
Contributor Author

ilovezfs commented Jul 4, 2017

Some of these will still be broken since the PR only adds -L#{lib}, which still leaves breakage if there are libraries used from other formulae too.

no /usr/local/lib for you
no /usr/local/lib for you
no /usr/local/lib for you
no /usr/local/lib for you
no /usr/local/lib for you
no /usr/local/lib for you
no /usr/local/lib for you
@ilovezfs ilovezfs merged commit 604d5e3 into Homebrew:master Jul 5, 2017
@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant