Erlang: apply patch for macOS 10.13 BoringSSL issue.

[idyll]

• Have you followed the guidelines for contributing?
• Have you checked that there aren't other open pull requests for the same formula update/change?
• Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

---

This PR applies the patch to erlang and applies a backported version of the patch to erlang@19.

I think we need to apply the patch now because this won't be fixed until the next official release at best, and pretty much any usage of erlang crypto will crash on 10.13.

I have built and tested on 10.12 as well as 10.13 although note that if you are using a fresh install of 10.13 you will need to use the prerelease build of the wxmac dependency (only for 10.13) or to install the dependency from a cask.

[idyll]

Brew audit-strict fails on the missing erlang@20 formula but I am not sure I need it. If I do I can make one, but this is a patch only change for future compatibility with High Sierra.

[idyll]

I am doing a backup and then will try an "in-place" upgrade to High Sierra to complete my testing.
I will report back to confirm, but I think this should be good to go.

I've looked at the logs and the failure appears to be the couchdb test itself.
I don't use it so I am probably not the guy for that one...

[ilovezfs]

@BrewTestBot test this please

[DomT4]

Is this supposed to be a formula revision or?

[idyll]

This is just a rebuild with a flag change needed for High Sierra. There are no changes. It's not a new version.

The new compiler flag prevents linking against BoringSSL on 10.13. It should have no effect on any other OS and the current behaviour on 10.13 is a bug.

I think bumping versions will confuse people hence the rebuild.

[DomT4]

Yeah, I'm just not sure why you're adding rebuild here manually. That'll get done by CI. There's no massive harm to adding it IIRC, but I was wondering if you were trying to bump the formula revision & misunderstood placement or such, was all 😃

[idyll]

I knew CI did the checksums, didn't know it added the rebuild. 👍

[idyll]

I have now verified this on High Sierra updated in place from Sierra. Things look good to me.

[idyll]

Also, just to verify brew test couchdb works for me.

brew test couchdb
Testing couchdb
==> Using the sandbox
==> /usr/local/Cellar/couchdb/1.6.1_10/bin/couchjs -h
Apache CouchDB 1.6.1 (LogLevel=info) is starting.
Apache CouchDB has started. Time to relax.
[info] [<0.56.0>] Apache CouchDB has started on http://127.0.0.1:5984/
==> curl -# localhost:5984
[info] [<0.129.0>] 127.0.0.1 - - GET / 200
######################################################################## 100.0%

[idyll]

@ilovezfs what should I do to fix this. Is there a way to tell CI to run again? I am not seeing the fail when I test CouchDB locally. Let me know what I need to do...

Also, the PR on erlang has been pulled in and will be released with 20.1 as expected. So once it drops we call pull this out.

[ilovezfs]

#15315 took care of couchdb

[ilovezfs]

@BrewTestBot test this please

[ilovezfs]

@idyll Excellent work. Thanks for your first contribution to Homebrew! Without people like you submitting PRs we couldn't run this project. You rock!

[pbadeer]

I'm still seeing this issue, I confirmed that I have this patch already but it hasn't fixed it.

[ilovezfs]

@idyll @bjorng any ideas on how to debug @pbadeer's findings?

[idyll]

@pbadeer can you try using the sierra bottle and see what happens:

brew reinstall erlang --force-bottle

I am confident it what the patch does. I'm wondering if erlang wasn't re-compiled.
I know there's a wxmac issue on the latest sierra again.

[idyll]

Another user reported this issue and they resolved it by re-installing erlang. In their case they had to uninstall an older version because their elixir was linked to it.

I assume you're having a similar issue.

Try uninstalling and reinstalling.

But if I was you I'd use the bottle because wxmac isn't compiling right now without a hack.

[DomT4]

@idyll wxmac builds fine from HEAD if you're desperate & don't want to have to fiddle with the formula.

[pbadeer]

@idyll Thanks for the suggestion. I ran brew reinstall erlang --force-bottle and re-ran mix deps.get and it worked!

[Grantimus9]

Thanks @idyll, this seems to have fixed erlang/elixir for me after upgrading to macOS High Sierra. 🔥

[mark-b-kauffman]

@idyll Worked for me too! I ran brew reinstall erlang --force-bottle and re-ran mix deps.get and it worked! Thanks a bunch!