Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created by
brew bump
Created with
brew bump-formula-pr
.release notes
dolt_fetch()
,dolt_pull()
, anddolt_push()
will need to have explicit grants to the procedures they need access to. See Documentation for more specifics.Per Dolt’s versioning policy, this is a minor version bump because these changes may impact existing applications. Please reach out to us on GitHub or Discord if you have questions or need help with any of these changes.
Merged PRs
dolt
Currently we encourage our users to grant execute permissions at the DB level, which gives users the ability to run somewhat privileged operations such as
dolt_gc
anddolt_push
. This change marks sensitive procedures such that explicit grants are required for sensitive features.Related: Procedure privledges dolthub/go-mysql-server#2110
GRPC upgrades, from dependabot.
This change takes out the schema check for tables with the same name that get modified. Previously, only tables that get dropped and re-added with the same name and same schema would get labelled as modified. Now, tables that get dropped and re-added with the same name regardless of schema will get labelled as modified.
Fixes:
dolt table import
withcreate
andforce
option fails to modify table in some instances dolthub/dolt#5738Updates the header generated by
dump-docs
go-mysql-server
This addresses a gap discovered while writing dolt tests - Grant Option on procedures is not currently validated correctly, resulting in only super users being able to set grants on procedures. This should address that.
As part of testing Dolt's reflog feature, I need to call
dolt_gc()
and then check the reflog behavior. Becausedolt_gc()
invalidates the session, I needed to add this hook that signals the test framework to create a new session for a ScriptTestAssertion.Adds support for respecting procedure and function permissions. Also added AdminOnly flag for external procedures to indicate that they should not have their privileges evaluated in the standard MySQL hierarchical way. This will allow us to tighten dolt procedures access.
The ability to grant access is still blocked behind an environment variable. That will remain until dolt changes have been released.
Convert many of the sqllogictests into enginetests for visibility
De Morgan's laws and leaf filter inversions to get NOT expressions as low in filter trees as possible. This will make index costing NOT filters easier.
Closed Issues
dolt table import
withcreate
andforce
option fails to modify table in some instancesdolt_history_$table