Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lima: MacOS.version >= ventura does not require qemu #154674

Closed
wants to merge 1 commit into from
Closed

lima: MacOS.version >= ventura does not require qemu #154674

wants to merge 1 commit into from

Conversation

LaszloGombos
Copy link

@LaszloGombos LaszloGombos commented Nov 17, 2023 •
edited
Loading

MacOS.version >= :ventura can use vz virtualization, do not force installation of qemu.

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@HappyTobi @AkihiroSuda

@github-actions github-actions bot added autosquash Automatically squash pull request commits according to Homebrew style. go Go use is a significant feature of the PR or issue labels Nov 17, 2023
@LaszloGombos
lima: MacOS.version >= ventura does not require qemu
0d1faff 
MacOS.version >= :ventura can use vz virtualization, do
not force installation of qemu.
@LaszloGombos LaszloGombos changed the title MacOS.version >= :ventura does not require qemu lima: MacOS.version >= ventura does not require qemu Nov 17, 2023
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Nov 17, 2023
@github-actions GitHub Actions
Copy link
Contributor

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

AkihiroSuda
AkihiroSuda reviewed Nov 17, 2023
View reviewed changes
Formula/l/lima.rb
@@ -17,7 +17,7 @@ class Lima < Formula
end

depends_on "go" => :build
depends_on "qemu"
depends_on "qemu" if MacOS.version < :ventura
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vz is still experimental and using qemu is recommended

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AkihiroSuda indeed. thanks.

While you're correct, on M3 for example qemu does not work currently - lima-vm/lima#1996. Making qemu mandatory let some of us believe that qemu is more stable.

Copy link
Contributor

@AkihiroSuda AkihiroSuda Nov 17, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On M1 and M2, qemu seems actually more stable

EDIT:
vz is more stable since Lima v0.19:

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, let's discuss this later, but this PR does not stop anyone to install or use qemu.
It does however forces people keep updating qemu even if they use vz.

@SMillerDev
Copy link
Member

Since its still experimental, let's keep qemu for now

@SMillerDev SMillerDev closed this Nov 17, 2023
@LaszloGombos
Copy link
Author

On M3 qemu does not seem to work, only vz works - abiosoft/colima#924, and yet brew forces qemu install.

@AkihiroSuda
Copy link
Contributor

AkihiroSuda commented Dec 12, 2023 •
edited
Loading

On M3 qemu does not seem to work, only vz works - abiosoft/colima#924, and yet brew forces qemu install.

Expected to be fixed in:

@HealsCodes
Copy link

HealsCodes commented Mar 30, 2024 •
edited
Loading

:optional is still not accepted in homebrew-core is it?

Otherwise this feels like a compromise:

depends_on "qemu" if MacOS.version < :ventura
depends_on "qemu" => :optional if MacOS.version >= :ventura

@SMillerDev
Copy link
Member

It is not, the only solution is for Lima to say it's not experimental anymore

@github-actions github-actions bot added the outdated PR was locked due to age label Apr 29, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AkihiroSuda AkihiroSuda AkihiroSuda left review comments

Assignees
No one assigned
Labels
go Go use is a significant feature of the PR or issue outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@LaszloGombos @SMillerDev @AkihiroSuda @HealsCodes