Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Linux-facing MacOS references #155012

Merged
merged 3 commits into from
Nov 21, 2023

Conversation

Rylan12
Copy link
Member

@Rylan12 Rylan12 commented Nov 21, 2023

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

See Homebrew/brew#16224

This PR removes calls to MacOS that could be accessed on Linux by adding on_macos blocks around the relevant patches in gcc@5 and gcc@6.

In the case of lsyncd, I've reworked the xnu resource to be dependent only on the major macOS version. As pointed out by @Bo98 here, bottles for lsyncd are only matched to a major version and there haven't been issues. Based on this, it seems safe to drop the specificity. When there were different versions for minor releases, I went with the most recent. For example, I used the macOS 14.1 xnu version (10002.41.9) for all Sonoma versions.

I marked this as syntax-only since I don't think we need new bottles or anything, but feel free to change that if we still want to test out the formulae more thoroughly.

@Rylan12 Rylan12 added the CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. label Nov 21, 2023
@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Nov 21, 2023
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Nov 21, 2023
@BrewTestBot BrewTestBot added this pull request to the merge queue Nov 21, 2023
Merged via the queue into Homebrew:master with commit db7cf37 Nov 21, 2023
14 checks passed
@MikeMcQuaid
Copy link
Member

Great work here, thanks @Rylan12!

@Rylan12 Rylan12 deleted the remove-macos-calls branch November 21, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants