Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

goresym 2.6.3 (new formula) #155716

Merged

Conversation

0xdevalias
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Add new formula for GoReSym CLI:

@github-actions github-actions bot added autosquash Automatically squash pull request commits according to Homebrew style. go Go use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core labels Nov 28, 2023
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Nov 28, 2023
@branchvincent branchvincent changed the title add goresym v2.6.3 goresym 2.6.3 (new formula) Nov 28, 2023
Formula/g/goresym.rb Outdated Show resolved Hide resolved
Copy link
Member

@chenrui333 chenrui333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one nit comment

@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Nov 28, 2023
@0xdevalias
Copy link
Contributor Author

LGTM, just one nit comment

@chenrui333 Accepted your changes :)

@chenrui333
Copy link
Member

@Oxyriser can you squash all the commits? Thanks!

Co-Authored-By: Rui Chen <rui@chenrui.dev>
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Nov 28, 2023
@0xdevalias
Copy link
Contributor Author

0xdevalias commented Nov 28, 2023

can you squash all the commits?

@chenrui333 I've squashed the commits and force pushed.. but honestly that really shouldn't be a blocker in the automation on this repo. PR's can be squash merged, which would solve this and other 'friction points' (like the CI blocking a PR because a certain commit within it is named poorly) without requiring manual process on each and every PR.

Edit: Raised this concern in the following:

@chenrui333
Copy link
Member

@0xdevalias thanks for your contribution! 🎉

Copy link
Contributor

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Nov 28, 2023
@BrewTestBot BrewTestBot added this pull request to the merge queue Nov 28, 2023
Merged via the queue into Homebrew:master with commit 8ce2d0f Nov 28, 2023
12 checks passed
@0xdevalias 0xdevalias deleted the 0xdevalias/add-formula-goresym branch November 30, 2023 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. go Go use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build release packages for linux/windows/macOS + add to homebrew package manager (macOS)
4 participants