Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnu-tar: prevent opportunistic gettext linkage #156184

Merged
merged 1 commit into from Dec 5, 2023

Conversation

alebcay
Copy link
Member

@alebcay alebcay commented Dec 2, 2023

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

This addresses #155992. No bottles needed since CI tightly controls deps present at build time; the issue is only encountered when users build from source.

@alebcay alebcay added CI-no-bottles Merge without publishing bottles CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Dec 2, 2023
@fxcoudert
Copy link
Member

fxcoudert commented Dec 3, 2023

I don't understand the logic. You're saying CI is not affected, “the issue is only encountered when users build from source”, but it would fix something that happens in CI?

@Bo98
Copy link
Member

Bo98 commented Dec 4, 2023

You're saying CI is not affected, “the issue is only encountered when users build from source”, but it would fix something that happens in CI?

It could happen in CI if built among something else that pulled in gettext, yes. The last gnu-tar bottle was built in isolation however without gettext and thus the existing bottles are fine and don't have this linkage. The issue here only happens with gettext installed.

@Bo98 Bo98 added the CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. label Dec 5, 2023
@Bo98 Bo98 added this pull request to the merge queue Dec 5, 2023
Merged via the queue into Homebrew:master with commit d0d47f7 Dec 5, 2023
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-no-bottles Merge without publishing bottles CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants