Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

syslog-ng 4.5.0 #156185

Merged
merged 2 commits into from
Dec 4, 2023
Merged

syslog-ng 4.5.0 #156185

merged 2 commits into from
Dec 4, 2023

Conversation

Porkepix
Copy link
Contributor

@Porkepix Porkepix commented Dec 2, 2023

Created by brew bump

Created with brew bump-formula-pr.

@github-actions github-actions bot added python Python use is a significant feature of the PR or issue bump-formula-pr PR was created using `brew bump-formula-pr` labels Dec 2, 2023
@ZhongRuoyu ZhongRuoyu force-pushed the bump-syslog-ng-4.5.0 branch 4 times, most recently from 7762110 to 57f67aa Compare December 2, 2023 15:47
@ZhongRuoyu
Copy link
Member

Kept hitting syslog-ng/syslog-ng#4496. First it was from the examples module, and now it's cloud-auth.

Essentially every C++ code that #includes lib/atomic-gssize.h would fail with Clang due to stricter type casting in C++. (Not sure why GCC allows that though -- it built on Linux.)

@bazsi
Copy link

bazsi commented Dec 3, 2023

I have made an attempt to work this around, but ultimately this is a bug in glib.

This is the workaround in syslog-ng: syslog-ng/syslog-ng#4739
This is the issue in glib: https://gitlab.gnome.org/GNOME/glib/-/issues/3193

@Porkepix @ZhongRuoyu
syslog-ng 4.5.0
8a541b0 
Co-authored-by: Ruoyu Zhong <zhongruoyu@outlook.com>
@ZhongRuoyu ZhongRuoyu added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Dec 3, 2023
@ZhongRuoyu
Copy link
Member

Thanks @bazsi!

@chenrui333 chenrui333 added the ready to merge PR can be merged once CI is green label Dec 4, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2023

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Dec 4, 2023
@BrewTestBot BrewTestBot added this pull request to the merge queue Dec 4, 2023
Merged via the queue into Homebrew:master with commit 5d68bbc Dec 4, 2023
12 checks passed
@github-actions github-actions bot added the outdated PR was locked due to age label Jan 4, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@github-actions github-actions[bot] github-actions approved these changes

@p-linnane p-linnane p-linnane approved these changes

Assignees
No one assigned
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. outdated PR was locked due to age python Python use is a significant feature of the PR or issue ready to merge PR can be merged once CI is green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@Porkepix @ZhongRuoyu @bazsi @HofiOne @p-linnane @chenrui333 @BrewTestBot