Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ruby-completion* 1.0.0 #157286

Merged
merged 8 commits into from
Dec 15, 2023
Merged

Conversation

chenrui333
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@chenrui333 chenrui333 changed the title ruby-completion*: update from f3e4345042b0cc48317e45b673dfd3d23904b9a7 to c5e03406eaf92e66d82788f599ab4eebd8dd561c ruby-completion*: update to use latest main Dec 13, 2023
@chenrui333 chenrui333 changed the title ruby-completion*: update to use latest main ruby-completion* 1.0.0 Dec 14, 2023
@chenrui333
Copy link
Member Author

chenrui333 commented Dec 14, 2023

@MikeMcQuaid
Copy link
Member

This is not the same because it's an actual downgrade.

In a case like this PR: using version_scheme is legitimate because it is an actual upgrade with an actual version scheme change.

@chenrui333
Copy link
Member Author

aha, I will use the version_scheme, thanks @MikeMcQuaid! 👍

Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
@chenrui333 chenrui333 added ready to merge PR can be merged once CI is green livecheck Issues or PRs related to livecheck labels Dec 14, 2023
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Dec 15, 2023
@BrewTestBot BrewTestBot added this pull request to the merge queue Dec 15, 2023
Merged via the queue into Homebrew:master with commit a516b01 Dec 15, 2023
12 checks passed
@github-actions github-actions bot added the outdated PR was locked due to age label Jan 15, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 15, 2024
@chenrui333 chenrui333 deleted the ruby-completion-update branch January 22, 2024 19:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. livecheck Issues or PRs related to livecheck outdated PR was locked due to age ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants