Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edencommon fb303 fbthrift fizz folly mvfst proxygen wangle watchman 2024.01.15.00 #160044

Merged
merged 18 commits into from
Jan 20, 2024

Conversation

timsutton
Copy link
Sponsor Member

@timsutton timsutton commented Jan 16, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@lnicco
Copy link

lnicco commented Jan 19, 2024

Thanks @timsutton for all the help reproducing the issue.
This commit should fix it
facebook/proxygen@343ffcb

Please let us know in case it doesn't

@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Jan 19, 2024
@timsutton timsutton force-pushed the fb-bump-2024.01.15.00 branch 2 times, most recently from 8dd2643 to a89515e Compare January 19, 2024 15:29
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Jan 19, 2024
@timsutton timsutton marked this pull request as ready for review January 19, 2024 15:31
@timsutton
Copy link
Sponsor Member Author

@p-linnane or @SMillerDev if you have a moment to review 🙏

Copy link
Member

@p-linnane p-linnane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work @timsutton! Thank you so much for resolving this long standing proxygen issue!

Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Jan 20, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Jan 20, 2024
Merged via the queue into Homebrew:master with commit 297ee0c Jan 20, 2024
12 checks passed
@github-actions github-actions bot added the outdated PR was locked due to age label Feb 20, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants