-
-
Notifications
You must be signed in to change notification settings - Fork 12.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
edencommon fb303 fbthrift fizz folly mvfst proxygen wangle watchman 2024.01.15.00 #160044
edencommon fb303 fbthrift fizz folly mvfst proxygen wangle watchman 2024.01.15.00 #160044
Conversation
Thanks @timsutton for all the help reproducing the issue. Please let us know in case it doesn't |
eeae3b7
to
2042ecb
Compare
8dd2643
to
a89515e
Compare
a89515e
to
526d136
Compare
@p-linnane or @SMillerDev if you have a moment to review 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work @timsutton! Thank you so much for resolving this long standing proxygen
issue!
🤖 An automated task has requested bottles to be published to this PR. |
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?proxygen
build + test working again. See edencommon fb303 fbthrift fizz folly mvfst proxygen wangle watchman 2024.01.08.00 #159369 for discussion in last week's versions.folly
test since Folly now assumes C++17 as a minimum