Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clinfo: update test #160229

Merged
merged 1 commit into from
Jan 19, 2024
Merged

clinfo: update test #160229

merged 1 commit into from
Jan 19, 2024

Conversation

p-linnane
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@p-linnane p-linnane added the CI-no-bottles Merge without publishing bottles label Jan 17, 2024
@alebcay
Copy link
Member

alebcay commented Jan 17, 2024

  ==> /opt/homebrew/Cellar/clinfo/3.0.23.01.25/bin/clinfo
  gatherPlatformInfo:1247: number of devices : error -30
  Number of platforms                               1
    Platform Name                                   Apple
    Platform Vendor                                 Apple
    Platform Version                                OpenCL 1.2 (Nov 11 2023 23:48:17)
    Platform Profile                                FULL_PROFILE
    Platform Extensions                             cl_APPLE_SetMemObjectDestructor cl_APPLE_ContextLoggingFunctions cl_APPLE_clut cl_APPLE_query_kernel_names cl_APPLE_gl_sharing cl_khr_gl_event
  Error: clinfo: failed
  An exception occurred within a child process:
    Minitest::Assertion: Expected: 0
    Actual: 1

Maybe it's still worth validating some other line of the output when running on ephemeral Apple Silicon CI (shell_output also accepts an optional non-zero expected return code)?

@p-linnane
Copy link
Member Author

Maybe it's still worth validating some other line of the output when running on ephemeral Apple Silicon CI (shell_output also accepts an optional non-zero expected return code)?

Good call. I've pushed a change that will look for the error we are seeing in ARM CI. Let's see how it goes.

@chenrui333 chenrui333 added CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. sonoma-bottling labels Jan 18, 2024
Formula/c/clinfo.rb Outdated Show resolved Hide resolved
Formula/c/clinfo.rb Outdated Show resolved Hide resolved
@p-linnane p-linnane force-pushed the clinfo-updates branch 2 times, most recently from 688550c to cfe716f Compare January 18, 2024 23:45
Signed-off-by: Patrick Linnane <patrick@linnane.io>
@p-linnane p-linnane added ready to merge PR can be merged once CI is green and removed CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Jan 18, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Jan 19, 2024
Merged via the queue into Homebrew:master with commit 28496fd Jan 19, 2024
22 checks passed
@p-linnane p-linnane deleted the clinfo-updates branch January 19, 2024 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-no-bottles Merge without publishing bottles ready to merge PR can be merged once CI is green sonoma-bottling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants