go 1.21.7 #161976
Merged
go 1.21.7 #161976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
bump-formula-pr
iMichka
approved these changes
Feb 6, 2024
|
It probably needs tags |
Merged
alebcay
added
long build
stefanb
added a commit
to stefanb/homebrew-core
that referenced
this pull request
Feb 7, 2024
It seems v0.9.4 it was re-tagged again, similar to * Homebrew#158001 This affects * Homebrew#161976 * Homebrew#157782
|
Cog is failing, handled in a separate PR: to not block this one. |
chenrui333
approved these changes
Feb 7, 2024
|
emp is failing due to webrick being unavailable for testing: Likely not related to Go upgrade, but a homebrew issue. Not sure what can be done about that. |
Maybe better doing it/rebasing it after merge then, so have it compiled using latest compiler release? (Or even the 1.22, but might take some time I guess) |
|
Could you make a pr where you revision bump emp? So we can figure that out later? |
stefanb
added a commit
to stefanb/homebrew-core
that referenced
this pull request
Feb 7, 2024
Related: * Homebrew#161976
6 tasks
Created: and it reproduces the problem, unrelated to any Go changes. |
|
Problematic formulae from https://github.com/Homebrew/homebrew-core/actions/runs/7806004183/job/21303080975?pr=161976:
|
This was referenced Feb 7, 2024
Merged
|
Judging from the errors so far it seems that the Go 1.21.7 is ok to merge and all of the problems are with individual projects / formulae. |
chenrui333
reviewed
Feb 8, 2024
|
considering this is just a patch version update, we can also probably skip building the dependants from source |
stefanb
force-pushed
the
bump-go-1.21.7
branch
from
4ec5f3f
to
2a6a703
Compare
|
It's building every dependents from source again @chenrui333 |
chenrui333
removed
the
CI-build-dependents-from-source
github-actions
bot
removed
the
CI-long-timeout
chenrui333
approved these changes
Feb 8, 2024
|
When not rebuilding every dependent, I guess the long build isn't needed anymore? |
github-actions
bot
removed
the
CI-long-timeout
|
🤖 An automated task has requested bottles to be published to this PR. |
github-actions
bot
added
the
CI-published-bottle-commits
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
alebcay
added a commit
to stefanb/homebrew-core
that referenced
this pull request
Feb 10, 2024
alebcay
added a commit
to stefanb/homebrew-core
that referenced
this pull request
Feb 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Announcement: https://groups.google.com/g/golang-announce/c/Qdkw_yX60TE/m/no34wVjNBwAJ
Release notes: https://go.dev/doc/devel/release#go1.21.7
Created with
brew bump-formula-pr.resourceblocks have been checked for updates.