Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dotslash 0.2.0 (new formula) #162300

Merged
merged 2 commits into from
Feb 12, 2024
Merged

dotslash 0.2.0 (new formula) #162300

merged 2 commits into from
Feb 12, 2024

Conversation

abhinav
Copy link
Contributor

@abhinav abhinav commented Feb 10, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Adds a formula for https://github.com/facebook/dotslash.
The tool helps download and run executables from the web.

brew audit --new passes except that the repository is fewer than 30 days old.
I'm happy to keep this PR as a draft for 30 days if that's a hard requirement.
FWIW, per the announcement blog post,
seems that the tool's been in use for a while—only the OSS repository is new.

Refs facebook/dotslash#11

@github-actions github-actions bot added new formula PR adds a new formula to Homebrew/homebrew-core rust Rust use is a significant feature of the PR or issue labels Feb 10, 2024
@abhinav abhinav marked this pull request as ready for review February 10, 2024 22:23
@p-linnane p-linnane added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Feb 11, 2024
@p-linnane
Copy link
Member

We can waive that requirement for the reasons you outlined.

@p-linnane p-linnane requested a review from a team February 11, 2024 16:17
@chenrui333
Copy link
Member

@abhinav, thanks for your contribution to Homebrew! 🎉 🥇

Without awesome contributors like you, it would be impossible to maintain Homebrew to the high level of quality users have come to expect. Thank you!!!!

Copy link
Contributor

Copy link
Contributor

⚠️ @chenrui333 bottle publish failed.

@chenrui333
Copy link
Member

homebrew/core
  * The following should either be an alias or a rename, not both: bigdata, boot2docker, camlistore, crystal-lang, findbugs, gitlab-ci-multi-runner, gnome-icon-theme, gnupg2, gtef, gtk+4, htop-osx, latexila, letsencrypt, libmongoclient, linux-headers, mat, mobile-shell, mongo-c, newsbeuter, osh, pyqt5, qt5, recipes, speedtest_cli, ssreflect, tachyon, tensorflow and transfig
Error: 1 problem in 1 tap detected.
Error: Failure while executing; `/home/linuxbrew/.linuxbrew/bin/brew audit --skip-style --debug dotslash` exited with 1.

Adds a formula for https://github.com/facebook/dotslash.
The tool helps download and run executables from the web.

`brew audit --new` passes except that the repository is
fewer than 30 days old.
Copy link
Contributor

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Feb 12, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Feb 12, 2024
Merged via the queue into Homebrew:master with commit 69de203 Feb 12, 2024
12 checks passed
@abhinav abhinav deleted the dotslash branch February 12, 2024 13:14
@github-actions github-actions bot added the outdated PR was locked due to age label Mar 14, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. new formula PR adds a new formula to Homebrew/homebrew-core outdated PR was locked due to age rust Rust use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants