Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

formulae: remove unnecessary crate livecheck blocks #162397

Merged
merged 2 commits into from
Feb 12, 2024

Conversation

samford
Copy link
Member

@samford samford commented Feb 12, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

We recently added a Crate strategy to livecheck (Homebrew/brew#16620), which uses similar logic to the pngquant livecheck block. We can now remove the livecheck blocks for oakc and pngquant, as the Crate strategy will work for these formulae by default.

@samford samford added livecheck Issues or PRs related to livecheck CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. labels Feb 12, 2024
@github-actions github-actions bot added the rust Rust use is a significant feature of the PR or issue label Feb 12, 2024
@chenrui333 chenrui333 changed the title Remove unnecessary crate livecheck blocks formulae: remove unnecessary crate livecheck blocks Feb 12, 2024
@chenrui333 chenrui333 added this pull request to the merge queue Feb 12, 2024
Merged via the queue into Homebrew:master with commit 09aaf63 Feb 12, 2024
14 checks passed
@samford samford deleted the remove-crate-livecheck branch February 13, 2024 19:28
@github-actions github-actions bot added the outdated PR was locked due to age label Mar 20, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. livecheck Issues or PRs related to livecheck outdated PR was locked due to age rust Rust use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants