Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yt-dlp: use gmake for head build #162967

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Conversation

Wallunen
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

yt-dlp/yt-dlp#9210

@github-actions github-actions bot added the python Python use is a significant feature of the PR or issue label Feb 16, 2024
Copy link
Member

@ZhongRuoyu ZhongRuoyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it actually fail when using make instead of gmake? Because GNU Make is already provided by macOS, and also required by Linuxbrew. I don't think we're using BSD Make anywhere.

@Wallunen
Copy link
Contributor Author

Does it actually fail when using make instead of gmake? Because GNU Make is already provided by macOS, and also required by Linuxbrew. I don't think we're using BSD Make anywhere.

It does fail on my Mac where /usr/bin/make is version 3.81.

Formula/y/yt-dlp.rb Outdated Show resolved Hide resolved
@ZhongRuoyu ZhongRuoyu added the CI-no-bottles Merge without publishing bottles label Feb 16, 2024
Copy link
Member

@ZhongRuoyu ZhongRuoyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Wallunen.

@BrewTestBot BrewTestBot added this pull request to the merge queue Feb 16, 2024
Merged via the queue into Homebrew:master with commit b1171d3 Feb 16, 2024
26 checks passed
@Wallunen Wallunen deleted the yt-dlp-gmake branch February 16, 2024 18:52
@github-actions github-actions bot added the outdated PR was locked due to age label Mar 17, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-no-bottles Merge without publishing bottles outdated PR was locked due to age python Python use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants