Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

erigon 2.58.1 #164590

Closed
wants to merge 1 commit into from
Closed

erigon 2.58.1 #164590

wants to merge 1 commit into from

Conversation

BrewTestBot
Copy link
Member

Created by brew bump

Created with brew bump-formula-pr.

release notes 
This patch release fixes syncing mainnet from scratch and also Issue #9472.

What's Changed



Full Changelog: ledgerwatch/erigon@v2.58.0...v2.58.1

@github-actions github-actions bot added go Go use is a significant feature of the PR or issue bump-formula-pr PR was created using `brew bump-formula-pr` labels Feb 29, 2024
@chenrui333 chenrui333 added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Feb 29, 2024
@cho-m
Copy link
Member

cho-m commented Feb 29, 2024

The issue here is libsilkworm_capi is a pre-built that is downloaded with silkworm-go source code and loaded from HOME directory.

The reason it fails on Monterey is the library needs C++20 to build (Xcode 14.3+, LLVM Clang 15+, GCC 11.2+). Upstream CI was probably newer macOS and not backwards compatible.

Upstream provides support for loading library from relative path, but next issue is libsilkworm needs Conan to build - https://github.com/erigontech/silkworm

I tried running cmake steps but it has hard failure if it can't find Conan.

At this point, our choice is either to deprecate formula or to include the pre-built and add a macos: :ventura requirement

cho-m added a commit that referenced this pull request Feb 29, 2024
@cho-m
erigon: deprecate
337cdd1 
Closes #164590

Signed-off-by: Michael Cho <michael@michaelcho.dev>
@cho-m cho-m mentioned this pull request Feb 29, 2024
Merged
6 tasks
cho-m added a commit that referenced this pull request Feb 29, 2024
@cho-m
erigon: deprecate
a66a57b 
Closes #164590

Signed-off-by: Michael Cho <michael@michaelcho.dev>
@p-linnane p-linnane deleted the bump-erigon-2.58.1 branch February 29, 2024 20:23
@github-actions github-actions bot added the outdated PR was locked due to age label Mar 31, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SMillerDev SMillerDev SMillerDev approved these changes

@nandahkrishna nandahkrishna nandahkrishna approved these changes

Assignees
No one assigned
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. go Go use is a significant feature of the PR or issue outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@BrewTestBot @cho-m @SMillerDev @nandahkrishna @chenrui333