New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
workflows/triage: CI-build-dependents-from-source
changes
#165416
Merged
cho-m
merged 1 commit into
Homebrew:master
from
cho-m:triage-CI-build-dependents-from-source
Mar 25, 2024
Merged
workflows/triage: CI-build-dependents-from-source
changes
#165416
cho-m
merged 1 commit into
Homebrew:master
from
cho-m:triage-CI-build-dependents-from-source
Mar 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
automerge-skip
`brew pr-automerge` will skip this pull request
workflows
PR modifies GitHub Actions workflow files
labels
Mar 7, 2024
May need to test afterward examples like:
|
cho-m
force-pushed
the
triage-CI-build-dependents-from-source
branch
3 times, most recently
from
March 8, 2024 03:48
41f77a6
to
b8eb9e5
Compare
cho-m
force-pushed
the
triage-CI-build-dependents-from-source
branch
from
March 23, 2024 17:24
b8eb9e5
to
df69edb
Compare
cho-m
force-pushed
the
triage-CI-build-dependents-from-source
branch
from
March 23, 2024 17:33
154ceec
to
df69edb
Compare
* Only label `ghc` and `go` formulae on major/minor version bumps by checking when the alias changes. This may break if we no longer need the alias, but it avoids having to introduce version parsing. * Ignore labeling formulae when only revision bumped or even situations where formula has an existing revision (as most cases we want to test on version bumps and those will always remove/reset the revision). One situation this doesn't help is non-bump PRs on a formula that has no revision stanza. * Set `allow_any_match` to label PRs when Alias and Formula need to be modified or when other revision bumps are needed. Signed-off-by: Michael Cho <michael@michaelcho.dev>
cho-m
force-pushed
the
triage-CI-build-dependents-from-source
branch
from
March 23, 2024 17:46
df69edb
to
7729899
Compare
fxcoudert
approved these changes
Mar 24, 2024
MikeMcQuaid
approved these changes
Mar 24, 2024
Thanks @cho-m! |
Going to give this a try. Will follow up if it isn't behaving as expected. |
🤖 An automated task has requested bottles to be published to this PR. |
|
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
outdated
PR was locked due to age
ready to merge
PR can be merged once CI is green
workflows
PR modifies GitHub Actions workflow files
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ghc
andgo
formulae on major/minor version bumps by checking when the alias changes. This may break if we no longer need the alias, but it avoids having to introduce version parsing.allow_any_match
to label PRs when Alias and Formula need to be modified or when other revision bumps are needed.HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?