-
-
Notifications
You must be signed in to change notification settings - Fork 12.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iconsur: prepare virtualenv to avoid issues with python@3.12
#165617
Conversation
Signed-off-by: Michael Cho <michael@michaelcho.dev>
@@ -333,6 +333,10 @@ | |||
"huggingface-cli": { | |||
"exclude_packages": ["certifi"] | |||
}, | |||
"iconsur": { | |||
"package_name": "", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need this line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's special brew
logic I added to allow brew update-python-resources iconsur
to work (since iconsur
is not a Python package).
Once I finish Homebrew/brew#16780, bump
/bump-formula-pr
will automatically update resources.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, good to know 👍
🤖 An automated task has requested bottles to be published to this PR. |
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?Supersedes and closes #163904