Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

octave 9.1.0 #166414

Merged
merged 6 commits into from
Mar 18, 2024
Merged

octave 9.1.0 #166414

merged 6 commits into from
Mar 18, 2024

Conversation

BrewTestBot
Copy link
Member

Created by brew bump

Created with brew bump-formula-pr.

@github-actions github-actions bot added java Java use is a significant feature of the PR or issue bump-formula-pr PR was created using `brew bump-formula-pr` labels Mar 17, 2024
@chenrui333
Copy link
Member 

==> /opt/homebrew/opt/octave/bin/octave --no-gui -H --path /opt/homebrew/Cellar/dynare/6.0_1/lib/dynare/matlab dyn_test.m
  warning: function /opt/homebrew/Cellar/dynare/6.0_1/lib/dynare/matlab/+identification/display.m shadows a built-in function
  warning: function /opt/homebrew/Cellar/dynare/6.0_1/lib/dynare/matlab/+identification/display.m shadows a built-in function
  warning: function /opt/homebrew/Cellar/dynare/6.0_1/lib/dynare/matlab/+identification/display.m shadows a built-in function
  warning: function /opt/homebrew/Cellar/dynare/6.0_1/lib/dynare/matlab/+identification/display.m shadows a built-in function
  warning: function /opt/homebrew/Cellar/dynare/6.0_1/lib/dynare/matlab/+identification/display.m shadows a built-in function
  warning: function /opt/homebrew/Cellar/dynare/6.0_1/lib/dynare/matlab/+identification/display.m shadows a built-in function
  ans = /private/tmp/dynare-test-20240317-44571-2uoaiq/octave
  warning: function /opt/homebrew/Cellar/dynare/6.0_1/lib/dynare/matlab/+identification/display.m shadows a built-in function
  warning: called from
      unpack at line 273 column 5
      untar at line 48 column 5
      install at line 99 column 9
      pkg at line 619 column 9
      dyn_test at line 3 column 1
  
  warning: function /opt/homebrew/Cellar/dynare/6.0_1/lib/dynare/matlab/+identification/display.m shadows a built-in function
  warning: called from
      unpack at line 280 column 5
      untar at line 48 column 5
      install at line [99](https://github.com/Homebrew/homebrew-core/actions/runs/8317665386/job/22758735600?pr=166414#step:3:100) column 9
      pkg at line 619 column 9
      dyn_test at line 3 column 1
  
  ld: library 'octinterp' not found
  collect2: error: ld returned 1 exit status
  make: *** [all] Error 1
  /opt/homebrew/Cellar/octave/9.1.0/bin/mkoctfile-9.1.0       libsvmread.cc
  
  error: pkg: error running 'make' for the statistics package
  error: called from
      configure_make at line 117 column 9
      install at line 202 column 7
      pkg at line 619 column 9
      dyn_test at line 3 column 1
  
  Error: dynare: failed
  An exception occurred within a child process:
    BuildError: Failed executing: /opt/homebrew/opt/octave/bin/octave --no-gui -H --path /opt/homebrew/Cellar/dynare/6.0_1/lib/dynare/matlab dyn_test.m

@chenrui333 chenrui333 added the test failure CI fails while running the test-do block label Mar 17, 2024
BrewTestBot and others added 3 commits March 17, 2024 21:38
@BrewTestBot @cho-m
octave 9.1.0
926b51d 
Signed-off-by: Michael Cho <michael@michaelcho.dev>
@timsutton @cho-m
dynare: revision bump (octave-9.1.0)
f456257
@cho-m
qscintilla2: migrate to Qt 6
ce9bebf 
Signed-off-by: Michael Cho <michael@michaelcho.dev>
cho-m
cho-m reviewed Mar 18, 2024
View reviewed changes
Formula/o/octave.rb
Comment on lines -65 to +62
depends_on "qt@5"
depends_on "qt"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to have to look into this a bit as our Qt6 is missing pkg-config files.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sadly Qt only provides .pc files on Linux. It's a bit tricky to generate full set of QT_CPPFLAGS and QT_LIBS due to recursive requirements and nested directory structure. Will switch back to Qt5 until this is figured out on either end (i.e. Qt supports macOS pkg-config files or GNU Octave supports CMake builds, neither seems likely).

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was merged with the broken Qt support. So, users currently don't have a GUI:
https://savannah.gnu.org/bugs/?65481

See also this previous attempt which looks like it could work now with Octave 9:
https://github.com/Homebrew/homebrew-core/pull/141675/files

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was trying something similar locally (parsing the libs out of configure and building up -I and -framework) but I think the indirect requirements cause issues.

I am trying another workaround but in Qt itself to generate some unofficial pkg-config files (#166463). No idea if it will work.

Otherwise, can migrate only Linux to Qt6 and use Qt5 on macOS with a qscintilla2-qt5 formula.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am trying another workaround but in Qt itself to generate some unofficial pkg-config files (#166463).

That would be perfect. 🙏
Currently, we are hardcoding the flags for Qt6 in the CI using Homebrew:
https://github.com/gnu-octave/octave/blob/2e5b29aff6ac54472bcecf4b6245616555aabb81/.github/workflows/make.yaml#L431-L435

Actually having pkg-config file for Qt6 on macOS would make that a lot easier. 👍

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My version of hardcoded Qt flags: #166551

pkg-config files would be cleaner though.

@github-actions GitHub Actions
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Mar 18, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Mar 18, 2024
Merged via the queue into master with commit 24fecc4 Mar 18, 2024
13 checks passed
@BrewTestBot BrewTestBot deleted the bump-octave-9.1.0 branch March 18, 2024 07:10
@kintel
Copy link
Contributor

kintel commented Mar 18, 2024

It would be nice to keep a qscintilla2-qt5 package around as well: While OpenSCAD doesn't have an official brew package, our brew build is still based on Qt5 and requires QScintilla2.
This PR broke our CI builds as those are based on brew.

We have a Qt6 upgrade in progress, but it's not stable yet..

This was referenced Mar 18, 2024
Closed
Open
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 19, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cho-m cho-m cho-m left review comments

@aWZHY0yQH81uOYvH aWZHY0yQH81uOYvH aWZHY0yQH81uOYvH left review comments

@mmuetzel mmuetzel mmuetzel left review comments

@carlocab carlocab carlocab approved these changes

@github-actions github-actions[bot] github-actions approved these changes

Assignees
No one assigned
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. java Java use is a significant feature of the PR or issue outdated PR was locked due to age test failure CI fails while running the test-do block
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@BrewTestBot @chenrui333 @kintel @cho-m @carlocab @aWZHY0yQH81uOYvH @mmuetzel @timsutton