manim 0.18.0 (new formula) #166434
Merged
manim 0.18.0 (new formula) #166434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
automerge-skip
github-actions
bot
removed
the
automerge-skip
SMillerDev
reviewed
Mar 18, 2024
|
Yeah, just confused how it built locally. On it! |
|
Apparently not cython—it's the same error I got when working on this previously: What's odd is I've only ever seen this error in the Homebrew GitHub runner environment and never locally, even on the same platform (macos 14-arm64 or macos 15-arm64). If anyone has a clue, would love some help. Otherwise, back to work! |
|
Think I may have figured it out: @SMillerDev May I request a |
|
omg vict’ry squashing! |
github-actions
bot
added
autosquash
github-actions
bot
removed
the
autosquash
unitof
force-pushed
the
add-manim
branch
4 times, most recently
from
4707d69
to
521c6bc
Compare
SMillerDev
reviewed
Mar 19, 2024
Note that this is the Community Edition (manim.community). A year in the making. I learned a lot about Python & homebrew & makefiles & GitHub runners Squashing a whole bunch of things, see Homebrew/homebrew-core@master...unitof:homebrew-core:add-manim-presquash for full unsquashed history. ORIGINAL COMMIT MESSAGES: Add ninja build dependency Codify Apple Silicon-only deps Alphabetize deps, uncomment recommended Write test placeholder Remove mactex dep for now manim (new formula) manim: add HEAD manim: add cairo build dependency manim: bump to latest version manim: Move to lettered folder manim: bump-formula-pr --write-only to 0.18.0 manim: switch to poet via poetry resources blocks 1019 poetry install 1025 poetry run manim 1028 poetry add homebrew-pypi-poet 1030 poetry run poet manim manim: bump python to 3.12 manim: fix build error with pyglet resource See pyglet/pyglet#999 Approach borrowed from iredis.rb manim: fix missing pyproject.toml field manim: more flit requirements manim: more pyglet patches Now seems to fully address pyglet/pyglet#999 Note: tried doing these as a patch to avoid so many `inreplace`ments, but turns out patches cannot be applied to resources (as far as I could determine). Related: Homebrew/legacy-homebrew#31508 Postnote: IT BUILDS WITHOUT ERROR NOW! manim: link properly manim: install missing resources manim: update install manim: add cython build dependency manim: cairo to runtime dep manim: attempt pkg-config build dep manim: attempt linux build fix (cmake missing from buildpath?) manim: add linux build dependency manim: add aclocal linux dep manim: simplify linux deps manim: pyobjc not compatible with linux manim: correct way to reject pyobjc on linux Stolen from gimme-aws-creds manim: fix missing pkg_resources manim: use Homebrew numpy manim: switch to native homebrew deps instead of PyPI resources, for all non-deprecated homebrew formulae dependencies manim: pygments must be a resource, not brew formula manim: certifi required for runtime manim: last known good configuration until I learn more about depends_on vs. resource blocks https://github.com/orgs/Homebrew/discussions/5211
SMillerDev
approved these changes
Mar 20, 2024
This was referenced Mar 21, 2024
chenrui333
reviewed
Apr 3, 2024
| depends_on "ffmpeg" | ||
| depends_on "numpy" | ||
| depends_on "py3cairo" | ||
| depends_on "python-setuptools" # for `import pkg_resources` |
There was a problem hiding this comment.
any issue tracker for dropping setuptools dep?
chenrui333
approved these changes
Apr 3, 2024
|
@unitof, thanks for your contribution to Homebrew! 🎉 🥇 Without awesome contributors like you, it would be impossible to maintain Homebrew to the high level of quality users have come to expect. Thank you!!!! |
github-actions
bot
added
the
CI-published-bottle-commits
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Hello! Is this package any different than the pip version? It seems like after installing, I can't import it through python. Any help is appreciated! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?At last! After months of (sporadic) debugging and half learning a ton about Python packagers and builders and finding one very sneaky upstream bug:
manim.