Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vulkan 1.3.285 formulas #167085

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Vulkan 1.3.285 formulas #167085

wants to merge 9 commits into from
+39 −40

Conversation

pthariensflame
Copy link
Sponsor Contributor

@pthariensflame pthariensflame commented Mar 25, 2024 •
edited

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@chenrui333 chenrui333 added the in progress Stale bot should stay away label Mar 26, 2024
@chenrui333
Copy link
Member

looks like just vulkan-tools missing 1.3.281 release?

@pthariensflame
Copy link
Sponsor Contributor Author

looks like just vulkan-tools missing 1.3.281 release?

That's correct! Should we just revision-bump it for now?

@cho-m
Copy link
Member

cho-m commented Apr 11, 2024

looks like just vulkan-tools missing 1.3.281 release?

That's correct! Should we just revision-bump it for now?

It sounds like upstream is skipping 281 - KhronosGroup/Vulkan-Tools#975 (comment)

@pthariensflame
Copy link
Sponsor Contributor Author

@cho-m @chenrui333 Should we just skip this one, then, and only do 1.3.282 all at once?

@chenrui333
Copy link
Member

sounds good to me.

@pthariensflame pthariensflame changed the title Vulkan 1.3.281 formulas Vulkan 1.3.282 formulas Apr 17, 2024
@pthariensflame pthariensflame force-pushed the vulkan-1.3.281 branch 2 times, most recently from 13112a0 to 5b5a53b Compare April 18, 2024 20:22
@pthariensflame pthariensflame changed the title Vulkan 1.3.282 formulas Vulkan 1.3.283 formulas Apr 20, 2024
@pthariensflame pthariensflame force-pushed the vulkan-1.3.281 branch 2 times, most recently from ddbb9b5 to e70caec Compare April 23, 2024 23:51
@pthariensflame pthariensflame marked this pull request as ready for review April 23, 2024 23:52
@pthariensflame
Copy link
Sponsor Contributor Author

@chenrui333 Should be ready!

@pthariensflame
Copy link
Sponsor Contributor Author

I have no idea what went wrong in CI. Getting permission errors while installing a normal bottle to the expected prefix shouldn’t happen.

@cho-m
Copy link
Member

cho-m commented Apr 24, 2024

vulkan-tools needs some updates KhronosGroup/Vulkan-Tools@c5d71df:

  Error: inreplace failed
  /private/tmp/vulkan-tools-20240423-14307-mq1pf7/Vulkan-Tools-1.3.283/cube/macOS/cube/CMakeLists.txt:
    expected replacement of "${MOLTENVK_DIR}/MoltenVK/dylib/macOS/libMoltenVK.dylib" with "${MOLTENVK_DIR}/lib/libMoltenVK.dylib"
  /private/tmp/vulkan-tools-20240423-14307-mq1pf7/Vulkan-Tools-1.3.283/cube/macOS/cubepp/CMakeLists.txt:
    expected replacement of "${MOLTENVK_DIR}/MoltenVK/dylib/macOS/libMoltenVK.dylib" with "${MOLTENVK_DIR}/lib/libMoltenVK.dylib"

@pthariensflame
Copy link
Sponsor Contributor Author

VK_ERROR_INCOMPATIBLE_DRIVER: Vulkan is not supported on this device. MoltenVK requires Metal, which is not available on this device.

Okay. I guess all the macOS VMs have this problem now. :/

@pthariensflame
Copy link
Sponsor Contributor Author

vulkan-tools needs some updates KhronosGroup/Vulkan-Tools@c5d71df:

  Error: inreplace failed
  /private/tmp/vulkan-tools-20240423-14307-mq1pf7/Vulkan-Tools-1.3.283/cube/macOS/cube/CMakeLists.txt:
    expected replacement of "${MOLTENVK_DIR}/MoltenVK/dylib/macOS/libMoltenVK.dylib" with "${MOLTENVK_DIR}/lib/libMoltenVK.dylib"
  /private/tmp/vulkan-tools-20240423-14307-mq1pf7/Vulkan-Tools-1.3.283/cube/macOS/cubepp/CMakeLists.txt:
    expected replacement of "${MOLTENVK_DIR}/MoltenVK/dylib/macOS/libMoltenVK.dylib" with "${MOLTENVK_DIR}/lib/libMoltenVK.dylib"

And given the root of this problem, we may be blocked until we upgrade molten-vk.

@pthariensflame
Copy link
Sponsor Contributor Author

Trying things by reincorporating #166005 before the rest of the commits.

@pthariensflame
Copy link
Sponsor Contributor Author

Yeah. Between the macOS 13 runners having weird DB read issues, and AS Mac runners starting to exhibit the same missing-Metal problem previously plaguing Intel Mac runners, I'm inclined to think this is a CI issue. Who should we ask to take a look at that?

@cho-m cho-m added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Apr 26, 2024
@cho-m
Copy link
Member

cho-m commented Apr 26, 2024

the macOS 13 runners having weird DB read issues

Wasn't the workaround was added in #149337 to deal with this?

@pthariensflame
Copy link
Sponsor Contributor Author

Okay; I've readded the thing from #149337; now macOS 13 passes! But macOS 14 and macOS 12 don't, for different apparent reasons each. macOS 12 runners have the missing-Metal issue; macOS 14 runners have some file conflict with spirvCross.a that prevented molten-vk from building.

@pthariensflame
Copy link
Sponsor Contributor Author

And this time the macOS 12 Arm runner succeeded?????

@pthariensflame pthariensflame force-pushed the vulkan-1.3.281 branch 2 times, most recently from 3e3a849 to 6ca8558 Compare May 2, 2024 18:34
@pthariensflame pthariensflame changed the title Vulkan 1.3.283 formulas Vulkan 1.3.284 formulas May 6, 2024
@ottob
Copy link
Contributor

ottob commented May 9, 2024

moltenvk 1.2.9 has been released now. maybe that will work better?

https://github.com/KhronosGroup/MoltenVK/releases/tag/v1.2.9

@pthariensflame
Copy link
Sponsor Contributor Author

pthariensflame commented May 9, 2024 •
edited

Just waiting on vulkan-extensionlayer again now. All is ready!

@pthariensflame
Copy link
Sponsor Contributor Author

pthariensflame commented May 10, 2024 •
edited

@cho-m @chenrui333 @ottob Even though Vulkan 1.3.285 is starting to exist (vulkan-headers has already been updated), I'm choosing to stick with 1.3.284 for this PR, assuming everything builds okay now, just so we don't have to delay any further. I'll produce the 1.3.285 PR once this one is merged (if that's soon enough).

EDIT: Doing the same with 1.3.285 now.

@pthariensflame
Copy link
Sponsor Contributor Author

Okay, no, MoltenVK is still failing to build for some reason.

@pthariensflame
Copy link
Sponsor Contributor Author

I guess we'll see if 1.3.285 makes any difference.

@pthariensflame pthariensflame changed the title Vulkan 1.3.284 formulas Vulkan 1.3.285 formulas May 14, 2024
@pthariensflame pthariensflame force-pushed the vulkan-1.3.281 branch 3 times, most recently from c0af3ef to 8e20794 Compare May 21, 2024 02:41
@pthariensflame pthariensflame force-pushed the vulkan-1.3.281 branch 2 times, most recently from 3e31095 to dfb14ec Compare May 31, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. in progress Stale bot should stay away
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pthariensflame @chenrui333 @cho-m @ottob