Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chainhook 1.5.1 (new formula) #168028

Merged

Conversation

MicaiahReid
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added new formula PR adds a new formula to Homebrew/homebrew-core rust Rust use is a significant feature of the PR or issue labels Apr 4, 2024
Copy link
Contributor

github-actions bot commented Apr 4, 2024

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Apr 4, 2024
Formula/c/chainhook.rb Outdated Show resolved Hide resolved
Formula/c/chainhook.rb Outdated Show resolved Hide resolved
@MicaiahReid MicaiahReid marked this pull request as draft April 4, 2024 19:34
Formula/c/chainhook.rb Outdated Show resolved Hide resolved
@chenrui333 chenrui333 mentioned this pull request Apr 4, 2024
6 tasks
Formula/c/chainhook.rb Outdated Show resolved Hide resolved
@SMillerDev
Copy link
Member

Unable to find libclang: "couldn't find any valid shared libraries matching: ['libclang.so', 'libclang-*.so', 'libclang.so.*', 'libclang-*.so.*'], set the `LIBCLANG_PATH` environment variable to a path where one of these files can be found (invalid: [])"

@MicaiahReid MicaiahReid changed the title chainhook 1.4.1 (new formula) chainhook 1.5.1 (new formula) Apr 15, 2024
@MicaiahReid MicaiahReid marked this pull request as ready for review April 15, 2024 20:51
@MicaiahReid
Copy link
Contributor Author

@chenrui333 @SMillerDev I have addressed your comments!

I thought I fixed all of the commit messages to match the expected style, but it still is failing CI on that point.

Formula/c/chainhook.rb Outdated Show resolved Hide resolved
Formula/c/chainhook.rb Outdated Show resolved Hide resolved
@MicaiahReid
Copy link
Contributor Author

@chenrui333 Could I get a re-review on this?

Formula/c/chainhook.rb Outdated Show resolved Hide resolved
@chenrui333
Copy link
Member

@MicaiahReid one last comment, can you also squash all your commits as well? And add this formula into autobump.txt file. Thanks!

@chenrui333 chenrui333 added the almost there PR is nearly ready to merge label May 2, 2024
@github-actions github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request autobump labels May 6, 2024
@MicaiahReid MicaiahReid force-pushed the new-formula-chainhook-1.4.1 branch from 355741d to ec9bc08 Compare May 6, 2024 17:13
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label May 6, 2024
@MicaiahReid MicaiahReid force-pushed the new-formula-chainhook-1.4.1 branch from 19fb5af to 9a1fbb8 Compare May 6, 2024 18:37
@MicaiahReid
Copy link
Contributor Author

@chenrui333 Thanks for the feedbacks! I think this should be good to go 🚀

@chenrui333 chenrui333 removed almost there PR is nearly ready to merge automerge-skip `brew pr-automerge` will skip this pull request labels May 7, 2024
@chenrui333
Copy link
Member

@MicaiahReid, thanks for your first contribution to homebrew-core!! 🎉 🥇

Without awesome contributors like you, it would be impossible to maintain Homebrew to the high level of quality users have come to expect. Thank you!!!!

Copy link
Contributor

github-actions bot commented May 7, 2024

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label May 7, 2024
@BrewTestBot BrewTestBot enabled auto-merge May 7, 2024 14:44
@BrewTestBot BrewTestBot added this pull request to the merge queue May 7, 2024
Merged via the queue into Homebrew:master with commit 1289482 May 7, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autobump CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. new formula PR adds a new formula to Homebrew/homebrew-core rust Rust use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants