Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

six: use pip #168155

Merged
merged 2 commits into from
Apr 6, 2024
Merged

six: use pip #168155

merged 2 commits into from
Apr 6, 2024

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Apr 5, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

May be able to keep an all bottle now.

Want to try to deprecate Language::Python.setup_install_args given it no longer simply works in python@3.12.

@cho-m
Copy link
Member Author

cho-m commented Apr 5, 2024

Looks like different versions of wheel are getting used. May be build-isolation is behaving differently.

diffoscope six--1.16.0_4.sonoma.bottle.1.tar.gz six--1.16.0_4.x86_64_linux.bottle.1.tar.gz
--- six--1.16.0_4.sonoma.bottle.1.tar.gz
+++ six--1.16.0_4.x86_64_linux.bottle.1.tar.gz
│   --- six--1.16.0_4.sonoma.bottle.1.tar
├── +++ six--1.16.0_4.x86_64_linux.bottle.1.tar
│ ├── six/1.16.0_4/lib/python3.12/site-packages/six-1.16.0.dist-info/WHEEL
│ │ @@ -1,6 +1,6 @@
│ │  Wheel-Version: 1.0
│ │ -Generator: bdist_wheel (0.42.0)
│ │ +Generator: bdist_wheel (0.43.0)
│ │  Root-Is-Purelib: true
│ │  Tag: py2-none-any
│ │  Tag: py3-none-any

I wonder if upgrading resource in python@3.12 will help.

@cho-m cho-m mentioned this pull request Apr 5, 2024
6 tasks
Signed-off-by: Michael Cho <michael@michaelcho.dev>
@cho-m cho-m marked this pull request as ready for review April 6, 2024 16:19
Copy link
Contributor

github-actions bot commented Apr 6, 2024

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Apr 6, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Apr 6, 2024
Merged via the queue into master with commit 2d9398b Apr 6, 2024
14 checks passed
@BrewTestBot BrewTestBot deleted the six-pip branch April 6, 2024 16:52
@cho-m cho-m mentioned this pull request Apr 11, 2024
6 tasks
@github-actions github-actions bot added the outdated PR was locked due to age label May 7, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants