-
-
Notifications
You must be signed in to change notification settings - Fork 12.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openjdk 22, openjdk@21 21.0.2 (new formula) #168294
openjdk 22, openjdk@21 21.0.2 (new formula) #168294
Conversation
Thanks @WangEdward, can you do this (and all the migrations to |
7823b9d
to
4ebbe86
Compare
@chenrui333 @ZhongRuoyu |
9f5cb0a
to
3e57d31
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes should help to fix the build failures. But please avoid pushing until CI finishes because it takes quite a long time to do one run. Thanks!
3e57d31
to
71dbf1d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@WangEdward, we seek your cooperation by avoid pushing to this branch before CI is completed. Due to
CI-build-dependents-from-source
60c9a91
to
a16046e
Compare
Sorry about that. I will make sure to push after all jobs are finished next time. I thought that the test results were likely to be the same for arm and intel machines, and if there are any extra failing items for intel, it's not likely to be an OpenJDK-related problem. The build time on intel machines is extensively long (>10 hrs), and if we are eventually going to run the whole test for all the machines, why bother wasting time on testing it at the first build? |
Although that's likely the case in general, it also comes with the assumption that the OpenJDK build itself performs as expected. We are usually more cautious with compilers, considering how they might affect users and also the dependent formulae. (And OpenJDK is a bit special in that formulae built with it also depend on it at runtime.)
Because subsequent tests will not be run with
CI-build-dependents-from-source
|
Guys, can you please create an issue to describe what has to be done to introduce openjdk@22? I'm a bit lost in this communication. |
At this moment all we need is patience. Many PRs are waiting for a long-timeout CI slot and we'll rerun CI here when the backlog is lighter. |
openjdk@21 21.0.3 has been released. Can we update this formula first? 22 non-LTS, I think can be dealt with later. PS: JDK Releases. |
|
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @WangEdward @SMillerDev @iMichka and everyone!
@WangEdward Hi guy, now this PR has been merged. Would you mind adding a new PR to update the latest |
|
Prepare for moving to OpenJDK 22 #166788