Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openjdk 22, openjdk@21 21.0.2 (new formula) #168294

Merged
merged 32 commits into from
Jun 5, 2024

Conversation

WangEdward
Copy link
Contributor

Prepare for moving to OpenJDK 22 #166788

@github-actions github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request new formula PR adds a new formula to Homebrew/homebrew-core labels Apr 8, 2024
@chenrui333 chenrui333 changed the title openjdk 21 lts openjdk@21 21.0.2 (new formula) Apr 8, 2024
@ZhongRuoyu
Copy link
Member

Thanks @WangEdward, can you do this (and all the migrations to openjdk@21) in #166788 instead? Otherwise we'd have two identical openjdk formulae before #166788 gets merged.

@chenrui333 chenrui333 marked this pull request as draft April 8, 2024 13:37
@github-actions github-actions bot added the CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. label Apr 8, 2024
@WangEdward WangEdward mentioned this pull request Apr 8, 2024
6 tasks
@WangEdward WangEdward marked this pull request as ready for review April 8, 2024 13:40
@WangEdward WangEdward changed the title openjdk@21 21.0.2 (new formula) openjdk 22, openjdk@21 21.0.2 (new formula) Apr 8, 2024
@WangEdward
Copy link
Contributor Author

WangEdward commented Apr 8, 2024

@chenrui333 @ZhongRuoyu
The commits in #166788 are too messy, so I moved everything here. Could you please add long build and CI-long-timeout to this? Thanks!

@ZhongRuoyu ZhongRuoyu added long build Needs CI-long-timeout CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-long-timeout Use longer GitHub Actions CI timeout. labels Apr 8, 2024
@ZhongRuoyu
Copy link
Member

Squashed b749377 and 9f5cb0a.

Copy link
Member

@ZhongRuoyu ZhongRuoyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes should help to fix the build failures. But please avoid pushing until CI finishes because it takes quite a long time to do one run. Thanks!

Formula/c/cbmc.rb Outdated Show resolved Hide resolved
Formula/o/openjdk.rb Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the CI-long-timeout Use longer GitHub Actions CI timeout. label Apr 9, 2024
Copy link
Member

@ZhongRuoyu ZhongRuoyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WangEdward, we seek your cooperation by avoid pushing to this branch before CI is completed. Due to CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. , the tests take a very long time and we don't want to start over after hours of run like this: https://github.com/Homebrew/homebrew-core/actions/runs/8602702349/job/23584693893?pr=168294.

Formula/s/scm-manager.rb Outdated Show resolved Hide resolved
@WangEdward
Copy link
Contributor Author

WangEdward commented Apr 9, 2024

@WangEdward, we seek your cooperation by avoid pushing to this branch before CI is completed. Due to CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. , the tests take a very long time and we don't want to start over after hours of run like this: https://github.com/Homebrew/homebrew-core/actions/runs/8602702349/job/23584693893?pr=168294.

Sorry about that. I will make sure to push after all jobs are finished next time.

I thought that the test results were likely to be the same for arm and intel machines, and if there are any extra failing items for intel, it's not likely to be an OpenJDK-related problem. The build time on intel machines is extensively long (>10 hrs), and if we are eventually going to run the whole test for all the machines, why bother wasting time on testing it at the first build?

@ZhongRuoyu
Copy link
Member

I thought that the test results were likely to be the same for arm and intel machines, and if there are any extra failing items for intel, it's not likely to be an OpenJDK-related problem.

Although that's likely the case in general, it also comes with the assumption that the OpenJDK build itself performs as expected. We are usually more cautious with compilers, considering how they might affect users and also the dependent formulae. (And OpenJDK is a bit special in that formulae built with it also depend on it at runtime.)

The build time on intel machines is extensively long (>10 hrs), and if we are eventually going to run the whole test for all the machines, why bother wasting time on testing it at the first build?

Because subsequent tests will not be run with CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. , once we have a complete list of what's broken.

@landsman
Copy link

Guys, can you please create an issue to describe what has to be done to introduce openjdk@22? I'm a bit lost in this communication.

@ZhongRuoyu
Copy link
Member

At this moment all we need is patience. Many PRs are waiting for a long-timeout CI slot and we'll rerun CI here when the backlog is lighter.

@calvinit
Copy link
Contributor

openjdk@21 21.0.3 has been released. Can we update this formula first? 22 non-LTS, I think can be dealt with later.

PS: JDK Releases.

@WangEdward
Copy link
Contributor Author

WangEdward commented Apr 17, 2024

openjdk@21 21.0.3 has been released. Can we update this formula first? 22 non-LTS, I think can be dealt with later.

PS: JDK Releases.

#170043

@WangEdward WangEdward mentioned this pull request Apr 25, 2024
@jfallows

This comment has been minimized.

@ZhongRuoyu ZhongRuoyu added the long dependent tests Set a long timeout for dependent testing label Jun 5, 2024
Copy link
Member

@ZhongRuoyu ZhongRuoyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @WangEdward @SMillerDev @iMichka and everyone!

Copy link
Contributor

github-actions bot commented Jun 5, 2024

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Jun 5, 2024
@github-actions github-actions bot added the CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. label Jun 5, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Jun 5, 2024
Merged via the queue into Homebrew:master with commit f85bc51 Jun 5, 2024
14 checks passed
@calvinit calvinit mentioned this pull request Jun 6, 2024
1 task
@WangEdward WangEdward deleted the openjdk-21-formula-update branch June 6, 2024 04:57
@calvinit
Copy link
Contributor

calvinit commented Jun 7, 2024

openjdk@21 21.0.3 has been released. Can we update this formula first? 22 non-LTS, I think can be dealt with later.
PS: JDK Releases.

#170043

@WangEdward Hi guy, now this PR has been merged. Would you mind adding a new PR to update the latest openjdk 22.0.1? Thanks.

@ZhongRuoyu
Copy link
Member

Would you mind adding a new PR to update the latest openjdk 22.0.1?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge-skip `brew pr-automerge` will skip this pull request CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. long build Needs CI-long-timeout long dependent tests Set a long timeout for dependent testing new formula PR adds a new formula to Homebrew/homebrew-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants