workflows/tests: fix tap_syntax style cache key
#168678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes the `tap_syntax` job for `brew`'s `master` branch incorrectly uses the cache from the `stable` job, because the cache restore key for the former is a prefix of the key for the latter. This can be seen in the following job, for example: https://github.com/Homebrew/homebrew-core/actions/runs/8652032061/job/23724090864. Fix that by adding `-master` to the `master` job's cache key, and updating the restore key accordingly.
github-actions
bot
added
workflows
chenrui333
approved these changes
Apr 11, 2024
carlocab
approved these changes
Apr 12, 2024
MikeMcQuaid
approved these changes
Apr 12, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?Sometimes the
tap_syntaxjob forbrew'smasterbranch incorrectly uses the cache from thestablejob, because the cache restore key for the former is a prefix of the key for the latter. This can be seen in the following job, for example:https://github.com/Homebrew/homebrew-core/actions/runs/8652032061/job/23724090864.
Fix that by adding
-masterto themasterjob's cache key, and updating the restore key accordingly.