Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloudflare-cli4 2.19.4 (new formula) #171268

Closed

Conversation

dgellow
Copy link
Contributor

@dgellow dgellow commented May 9, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Hi,

I'm opening this pull request to add a new formula to Homebrew for the CLI tool cli4 used to interact with Cloudflare API v4.

The audit is currently failing with:

cloudflare-cli4
  * GitHub repository not notable enough (<30 forks, <30 watchers and <75 stars)
Error: 1 problem in 1 formula detected.

The command line tool has been extracted from https://github.com/cloudflare/python-cloudflare to https://github.com/cloudflare/python-cloudflare-cli4 only yesterday, making it difficult for the repository to reach that level of notoriety. But the version that was packaged alongside cloudflare on PyPi exists since multiple years and has been advertised by Cloudflare (see this blog post for example: https://blog.cloudflare.com/python-cloudflare).

The next version of the python SDK won't be packaged with the CLI anymore and we want to ensure it stays available to current users.

I haven't contributed formulas to homebrews since a very long time, please tell me if I should correct anything.

This commit adds a new formula for Cloudflare's official CLI tool for the version 4 of the API.
The tool is fairly complex and can be used to interact with the API is various ways, some examples can be found in the README[0].

The project repository is at https://github.com/cloudflare/python-cloudflare-cli4.

`cli4`, the command line tool, was previously packaged as part of the `cloudflare` PyPi package but will now be packaged separately.

The homebrew package should be equivalent to the version published at PyPi[1] under the name cloudflare-cli4.

[0]: https://github.com/cloudflare/python-cloudflare-cli4/blob/main/README.md
[1]: https://pypi.org/project/cloudflare-cli4/
@github-actions github-actions bot added python Python use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core labels May 9, 2024
@chenrui333 chenrui333 changed the title Add Formula for cloudflare-cli4 cloudflare-cli4 2.19.4 (new formula) May 9, 2024
@chenrui333 chenrui333 added notability Project is not notable enough for inclusion CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. almost there PR is nearly ready to merge labels May 9, 2024
@github-actions github-actions bot added the outdated PR was locked due to age label Jun 23, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 23, 2024
@dgellow dgellow deleted the sam/add-cloudflare-cli4 branch June 24, 2024 14:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
almost there PR is nearly ready to merge CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. new formula PR adds a new formula to Homebrew/homebrew-core notability Project is not notable enough for inclusion outdated PR was locked due to age python Python use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants