Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jj: drop watchman dependency (but keep the feature) #171735

Merged
merged 1 commit into from
May 15, 2024

Conversation

chriskrycho
Copy link
Contributor

In a previous change, we added the Cargo feature for Jujutsu’s watchman integration, but since jj works fine without watchman, and watchman is a large dependency in its own right, switch it so the Jujutsu compilation feature is enabled, but the jj recipe does not depend on watchman: people who want the integration can install it themselves.

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added the rust Rust use is a significant feature of the PR or issue label May 15, 2024
@chriskrycho chriskrycho mentioned this pull request May 15, 2024
6 tasks
Formula/j/jj.rb Outdated Show resolved Hide resolved
In a previous change, we added the Cargo feature for Jujutsu’s watchman
integration, but since jj works fine without watchman, and watchman is a
large dependency in its own right, switch it so the Jujutsu compilation
feature is enabled, but the jj recipe does not depend on watchman:
people who want the integration can install it themselves.
@carlocab carlocab added the CI-no-bottles Merge without publishing bottles label May 15, 2024
@carlocab carlocab added this pull request to the merge queue May 15, 2024
Merged via the queue into Homebrew:master with commit 4c1516d May 15, 2024
23 checks passed
@chriskrycho chriskrycho deleted the jj-dep-tweak branch May 15, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-no-bottles Merge without publishing bottles rust Rust use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants