Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bitlbee: fix linkage and update license #172923

Merged
merged 1 commit into from
May 27, 2024
Merged

bitlbee: fix linkage and update license #172923

merged 1 commit into from
May 27, 2024

Conversation

Moisan
Copy link
Member

@Moisan Moisan commented May 27, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

This linkage check was failing (spotted in #172629)

> brew linkage --cached --test --strict bitlbee
Indirect dependencies with linkage:
  libgpg-error

I also updated the license since the source headers contains

  This program is free software; you can redistribute it and/or modify
  it under the terms of the GNU General Public License as published by
  the Free Software Foundation; either version 2 of the License, or
  (at your option) any later version.

For example see this file.

@Moisan
Copy link
Member Author

Moisan commented May 27, 2024

There is another bitlbee pr open for a different issue: #172018

@carlocab carlocab added the CI-no-bottles Merge without publishing bottles label May 27, 2024
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@carlocab carlocab enabled auto-merge May 27, 2024 10:16
@carlocab carlocab added this pull request to the merge queue May 27, 2024
Merged via the queue into master with commit 7b2b7b7 May 27, 2024
22 checks passed
@carlocab carlocab deleted the bitlbee_gpg_linkage branch May 27, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-no-bottles Merge without publishing bottles
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants