Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kibana 5.6.0 #17942

Closed
wants to merge 2 commits into from
Closed

kibana 5.6.0 #17942

wants to merge 2 commits into from

Conversation

jasontedor
Copy link
Contributor

Created with brew bump-formula-pr.

@fxcoudert
Copy link
Member

Lines 29–38 should be replaced by:

     # do not build packages for other platforms
     inreplace buildpath/"tasks/config/platforms.js", /('(linux-x64|windows-x64)',?(?!;))/, "// \\1"

Then line 31 becomes:

mkdir_p buildpath/".node_binaries/#{resource("node").version}/darwin-x64"

and line 48 becomes:

     prefix.install Dir["build/kibana-#{version}-darwin-x86_64/{bin,config,node_modules,optimize,package.json,src,ui_framework,webpackShims}"]

@jasontedor
Copy link
Contributor Author

@fxcoudert I am happy to look into making that change, but does it need to be done in a version bump PR?

@ilovezfs
Copy link
Contributor

I don't think I understand why any of those changes would need to be made, and no they do not need to be made in a version bump PR.

@ilovezfs ilovezfs closed this in ae4f6b5 Sep 11, 2017
@ilovezfs
Copy link
Contributor

Thanks @jasontedor! Shipped 🚀

@jasontedor
Copy link
Contributor Author

Thanks @ilovezfs!

@jasontedor jasontedor deleted the kibana-5.6.0 branch September 12, 2017 09:39
@ilovezfs
Copy link
Contributor

@jasontedor you're welcome! FYI, @fxcoudert made the tweaks he was describing above here: #17976

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants